Skip to content

Commit

Permalink
kbuild: drop V=0 support
Browse files Browse the repository at this point in the history
The top Makefile sets KBUILD_VERBOSE to 0 by default, it looks weird
now because V=1 and V=2 can be OR'ed as V=12. The default should be
empty.

Signed-off-by: Masahiro Yamada <[email protected]>
Reviewed-by: Nicolas Schier <[email protected]>
  • Loading branch information
masahir0y committed Jan 22, 2023
1 parent 6ae4b98 commit 83d98d7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Documentation/kbuild/makefiles.rst
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ more details, with real examples.
$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
@$(kecho) ' Kernel: $(boot)/$@ is ready'

When kbuild is executing with KBUILD_VERBOSE=0, then only a shorthand
When kbuild is executing with KBUILD_VERBOSE unset, then only a shorthand
of a command is normally displayed.
To enable this behaviour for custom commands kbuild requires
two variables to be set::
Expand All @@ -544,7 +544,7 @@ more details, with real examples.

GEN lib/crc32table.h

will be displayed with "make KBUILD_VERBOSE=0".
will be displayed with "make KBUILD_VERBOSE=".

3.12 Command change detection
-----------------------------
Expand Down
7 changes: 2 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ unexport GREP_OPTIONS
ifeq ("$(origin V)", "command line")
KBUILD_VERBOSE = $(V)
endif
ifndef KBUILD_VERBOSE
KBUILD_VERBOSE = 0
endif

quiet = quiet_
Q = @
Expand All @@ -102,7 +99,7 @@ endif

ifneq ($(findstring s,$(short-opts)),)
quiet=silent_
KBUILD_VERBOSE = 0
override KBUILD_VERBOSE :=
endif

export quiet Q KBUILD_VERBOSE
Expand Down Expand Up @@ -1774,7 +1771,7 @@ help:
printf " %-16s - Show all of the above\\n" help-boards; \
echo '')

@echo ' make V=n [targets] 0: quiet build (default), 1: verbose build'
@echo ' make V=n [targets] 1: verbose build'
@echo ' 2: give reason for rebuild of target'
@echo ' V=1 and V=2 can be combined with V=12'
@echo ' make O=dir [targets] Locate all output files in "dir", including .config'
Expand Down

0 comments on commit 83d98d7

Please sign in to comment.