Skip to content

Commit

Permalink
lib/test_sort.c: add module unload support
Browse files Browse the repository at this point in the history
test_sort.c performs array-based and linked list sort test.  Code allows
to compile either as a loadable modules or builtin into the kernel.

Current code is not allow to unload the test_sort.ko module after
successful completion.

This patch adds support to unload the "test_sort.ko" module by adding
module_exit support.

Previous patch was implemented auto unload support by returning -EAGAIN
from module_init() function on successful case, but this approach is not
ideal.

The auto-unload might seem like a nice optimization, but it encourages
inconsistent behaviour.  And behaviour that is different from all other
normal modules.

Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Pravin Shedge <[email protected]>
Cc: Kostenzer Felix <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Paul Gortmaker <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Pravin Shedge authored and torvalds committed Feb 7, 2018
1 parent d3deafa commit 92fc7cb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions lib/test_sort.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,11 @@ static int __init test_sort_init(void)
return err;
}

static void __exit test_sort_exit(void)
{
}

module_init(test_sort_init);
module_exit(test_sort_exit);

MODULE_LICENSE("GPL");

0 comments on commit 92fc7cb

Please sign in to comment.