Skip to content

Commit

Permalink
mips: bmips: setup: make CBR address configurable
Browse files Browse the repository at this point in the history
Add support to provide CBR address from DT to handle broken
SoC/Bootloader that doesn't correctly init it. This permits to use the
RAC flush even in these condition.

To provide a CBR address from DT, the property "brcm,bmips-cbr-reg"
needs to be set in the "cpus" node. On DT init, this property presence
will be checked and will set the bmips_cbr_addr value accordingly. Also
bmips_rac_flush_disable will be set to false as RAC flush can be
correctly supported.

The CBR address from DT will overwrite the cached one and the
one set in the CBR register will be ignored.

Also the DT CBR address is validated on being outside DRAM window.

Signed-off-by: Christian Marangi <[email protected]>
Acked-by: Florian Fainelli <[email protected]>
Signed-off-by: Thomas Bogendoerfer <[email protected]>
  • Loading branch information
Ansuel authored and tsbogend committed Jun 27, 2024
1 parent 3de96d8 commit b95b30e
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 4 deletions.
6 changes: 5 additions & 1 deletion arch/mips/bcm47xx/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,11 @@
#include <bcm47xx.h>
#include <bcm47xx_board.h>

/* CBR addr doesn't change and we can cache it */
/*
* CBR addr doesn't change and we can cache it.
* For broken SoC/Bootloader CBR addr might also be provided via DT
* with "brcm,bmips-cbr-reg" in the "cpus" node.
*/
void __iomem *bmips_cbr_addr __read_mostly;

union bcm47xx_bus bcm47xx_bus;
Expand Down
6 changes: 5 additions & 1 deletion arch/mips/bcm63xx/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,11 @@
#include <bcm63xx_io.h>
#include <bcm63xx_gpio.h>

/* CBR addr doesn't change and we can cache it */
/*
* CBR addr doesn't change and we can cache it.
* For broken SoC/Bootloader CBR addr might also be provided via DT
* with "brcm,bmips-cbr-reg" in the "cpus" node.
*/
void __iomem *bmips_cbr_addr __read_mostly;

void bcm63xx_machine_halt(void)
Expand Down
30 changes: 28 additions & 2 deletions arch/mips/bmips/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
#define REG_BCM6328_OTP ((void __iomem *)CKSEG1ADDR(0x1000062c))
#define BCM6328_TP1_DISABLED BIT(9)

/* CBR addr doesn't change and we can cache it */
/*
* CBR addr doesn't change and we can cache it.
* For broken SoC/Bootloader CBR addr might also be provided via DT
* with "brcm,bmips-cbr-reg" in the "cpus" node.
*/
void __iomem *bmips_cbr_addr __read_mostly;

extern bool bmips_rac_flush_disable;
Expand Down Expand Up @@ -208,13 +212,35 @@ void __init plat_mem_setup(void)
void __init device_tree_init(void)
{
struct device_node *np;
u32 addr;

unflatten_and_copy_device_tree();

/* Disable SMP boot unless both CPUs are listed in DT and !disabled */
np = of_find_node_by_name(NULL, "cpus");
if (np && of_get_available_child_count(np) <= 1)
if (!np)
return;

if (of_get_available_child_count(np) <= 1)
bmips_smp_enabled = 0;

/* Check if DT provide a CBR address */
if (of_property_read_u32(np, "brcm,bmips-cbr-reg", &addr))
goto exit;

/* Make sure CBR address is outside DRAM window */
if (addr >= (u32)memblock_start_of_DRAM() &&
addr < (u32)memblock_end_of_DRAM()) {
WARN(1, "DT CBR %x inside DRAM window. Ignoring DT CBR.\n",
addr);
goto exit;
}

bmips_cbr_addr = (void __iomem *)addr;
/* Since CBR is provided by DT, enable RAC flush */
bmips_rac_flush_disable = false;

exit:
of_node_put(np);
}

Expand Down

0 comments on commit b95b30e

Please sign in to comment.