Skip to content

Commit

Permalink
udf: Convert udf_expand_file_adinicb() to use a folio
Browse files Browse the repository at this point in the history
Use the folio APIs throughout this function.

Signed-off-by: Matthew Wilcox (Oracle) <[email protected]>
Fixes: 1eeceae ("udf: Convert udf_expand_file_adinicb() to avoid kmap_atomic()")
Signed-off-by: Jan Kara <[email protected]>
Message-Id: <[email protected]>
  • Loading branch information
Matthew Wilcox (Oracle) authored and jankara committed Apr 23, 2024
1 parent d08f069 commit db67540
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions fs/udf/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ const struct address_space_operations udf_aops = {
*/
int udf_expand_file_adinicb(struct inode *inode)
{
struct page *page;
struct folio *folio;
struct udf_inode_info *iinfo = UDF_I(inode);
int err;

Expand All @@ -358,12 +358,13 @@ int udf_expand_file_adinicb(struct inode *inode)
return 0;
}

page = find_or_create_page(inode->i_mapping, 0, GFP_KERNEL);
if (!page)
return -ENOMEM;
folio = __filemap_get_folio(inode->i_mapping, 0,
FGP_LOCK | FGP_ACCESSED | FGP_CREAT, GFP_KERNEL);
if (IS_ERR(folio))
return PTR_ERR(folio);

if (!PageUptodate(page))
udf_adinicb_readpage(page);
if (!folio_test_uptodate(folio))
udf_adinicb_readpage(&folio->page);
down_write(&iinfo->i_data_sem);
memset(iinfo->i_data + iinfo->i_lenEAttr, 0x00,
iinfo->i_lenAlloc);
Expand All @@ -372,22 +373,22 @@ int udf_expand_file_adinicb(struct inode *inode)
iinfo->i_alloc_type = ICBTAG_FLAG_AD_SHORT;
else
iinfo->i_alloc_type = ICBTAG_FLAG_AD_LONG;
set_page_dirty(page);
unlock_page(page);
folio_mark_dirty(folio);
folio_unlock(folio);
up_write(&iinfo->i_data_sem);
err = filemap_fdatawrite(inode->i_mapping);
if (err) {
/* Restore everything back so that we don't lose data... */
lock_page(page);
folio_lock(folio);
down_write(&iinfo->i_data_sem);
memcpy_to_page(page, 0, iinfo->i_data + iinfo->i_lenEAttr,
inode->i_size);
unlock_page(page);
memcpy_from_folio(iinfo->i_data + iinfo->i_lenEAttr,
folio, 0, inode->i_size);
folio_unlock(folio);
iinfo->i_alloc_type = ICBTAG_FLAG_AD_IN_ICB;
iinfo->i_lenAlloc = inode->i_size;
up_write(&iinfo->i_data_sem);
}
put_page(page);
folio_put(folio);
mark_inode_dirty(inode);

return err;
Expand Down

0 comments on commit db67540

Please sign in to comment.