Skip to content

Commit

Permalink
perf tests: Fix shellcheck warning in record_sideband.sh
Browse files Browse the repository at this point in the history
Running shellcheck on record_sideband.sh throws below
warning:

	In tests/shell/record_sideband.sh line 25:
	  if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null
	    ^--^ SC2069: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).

This shows shellcheck warning SC2069 where the redirection
order needs to be fixed. Use "cmd > /dev/null 2>&1" to fix
the redirection of perf record output

Fixes: 23b97c7 ("perf test: Add test case for record sideband events")
Signed-off-by: Athira Rajeev <[email protected]>
Reviewed-by: Kajol Jain <[email protected]>
Acked-by: Namhyung Kim <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Namhyung Kim <[email protected]>
  • Loading branch information
athira-rajeev authored and namhyung committed Oct 17, 2023
1 parent 47f5693 commit eff65ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/tests/shell/record_sideband.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ trap trap_cleanup EXIT TERM INT

can_cpu_wide()
{
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true 2>&1 >/dev/null
if ! perf record -o ${perfdata} -BN --no-bpf-event -C $1 true > /dev/null 2>&1
then
echo "record sideband test [Skipped cannot record cpu$1]"
err=2
Expand Down

0 comments on commit eff65ee

Please sign in to comment.