Skip to content

Commit

Permalink
kbuild: modules_install: warn when missing System.map file
Browse files Browse the repository at this point in the history
If there is no System.map file for "make modules_install",
scripts/depmod.sh will silently exit with success, having done
nothing.  Since this is an unexpected situation, change it to
report a Warning for the missing file.  The behavior is not
changed except for the Warning message.

The (previous) silent success and new Warning can be reproduced
by:
$ make mrproper; make defconfig
$ make modules; make modules_install

and since System.map is produced by "make vmlinux", the steps
above omit producing the System.map file.

Reported-by: Masahiro Yamada <[email protected]>
Signed-off-by: Randy Dunlap <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
  • Loading branch information
rddunlap authored and masahir0y committed Sep 9, 2018
1 parent 914b087 commit f0b0d88
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions scripts/depmod.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ DEPMOD=$1
KERNELRELEASE=$2

if ! test -r System.map ; then
echo "Warning: modules_install: missing 'System.map' file. Skipping depmod." >&2
exit 0
fi

Expand Down

0 comments on commit f0b0d88

Please sign in to comment.