Skip to content

Commit

Permalink
arm64: dts: qcom: acer-aspire1: Correct audio codec definition
Browse files Browse the repository at this point in the history
When initially added, a mistake was made in the definition of the codec.

Despite the fact that the DMIC line is connected on the side of the
codec chip, and relevant passive components, including 0-ohm resistors
connecting the dmics, are present, the dmic line is still cut in
another place on the board, which was overlooked.

Correct this by replacing the dmic configuration with a comment
describing this hardware detail.

While at it, also add missing regulators definitions. This is not a
functional change as all the relevant regulators were already added via
the other rail supplies.

Fixes: 4a9f8f8 ("arm64: dts: qcom: Add Acer Aspire 1")
Signed-off-by: Nikita Travkin <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Bjorn Andersson <[email protected]>
  • Loading branch information
TravMurav authored and andersson committed Dec 16, 2023
1 parent 04fe8f0 commit feec9f0
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,22 @@
AVDD-supply = <&vreg_l15a_1p8>;
MICVDD-supply = <&reg_codec_3p3>;
VBAT-supply = <&reg_codec_3p3>;
DBVDD-supply = <&vreg_l15a_1p8>;
LDO1-IN-supply = <&vreg_l15a_1p8>;

/*
* NOTE: The board has a path from this codec to the
* DMIC microphones in the lid, however some of the option
* resistors are absent and the microphones are connected
* to the SoC instead.
*
* If the resistors were to be changed by the user to
* connect the codec, the following could be used:
*
* realtek,dmic1-data-pin = <1>;
* realtek,dmic1-clk-pin = <1>;
*/

realtek,dmic1-data-pin = <1>;
realtek,dmic1-clk-pin = <1>;
realtek,jd-src = <1>;
};
};
Expand Down

0 comments on commit feec9f0

Please sign in to comment.