-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distinct method to FakeQuerySet #188
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,6 +3,7 @@ | |||||
import datetime | ||||||
import re | ||||||
|
||||||
from django.db import NotSupportedError, connection | ||||||
from django.db.models import Model, prefetch_related_objects | ||||||
|
||||||
from modelcluster.utils import extract_field_value, get_model_field, sort_by_fields | ||||||
|
@@ -516,6 +517,21 @@ def order_by(self, *fields): | |||||
clone = self.get_clone(results=self.results[:]) | ||||||
sort_by_fields(clone.results, fields) | ||||||
return clone | ||||||
|
||||||
def distinct(self, *fields): | ||||||
if fields and connection.vendor != 'postgresql': | ||||||
raise NotSupportedError("DISTINCT ON fields is not supported by this database backend") | ||||||
|
||||||
unique_results = [] | ||||||
if not fields: | ||||||
fields = [field.name for field in self.model._meta.fields if not field.primary_key] | ||||||
seen_keys = set() | ||||||
for result in self.results: | ||||||
key = '$$$'.join([str(extract_field_value(result, field)) for field in fields]) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I suggest using a tuple here - unlike lists, they're valid to use as keys within a set:
Suggested change
|
||||||
if key not in seen_keys: | ||||||
seen_keys.add(key) | ||||||
unique_results.append(result) | ||||||
return self.get_clone(results=unique_results) | ||||||
|
||||||
# a standard QuerySet will store the results in _result_cache on running the query; | ||||||
# this is effectively the same as self.results on a FakeQuerySet, and so we'll make | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed, given that we're bypassing the database here? I guess you're trying to keep FakeQuerySet as close as possible to the real database behaviour, but I think it's fine for FakeQuerySet to have extra functionality that the database doesn't support.