Make ApkBuilder less verbose (dotnet#37050)

The output is still pretty useful and x4 times less verbose.
waiyiptam · May 27, 2020 · 8b92b46 · 8b92b46
1 parent 32fdcaf
commit 8b92b46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tools-local/tasks/mobile.tasks/AndroidAppBuilder/ApkBuilder.cs b/tools-local/tasks/mobile.tasks/AndroidAppBuilder/ApkBuilder.cs
@@ -123,7 +123,7 @@ public class ApkBuilder
         string cmake = "cmake";
         string zip = "zip";
 
-        Utils.RunProcess(zip, workingDir: Path.Combine(OutputDir, "assets-tozip"), args: "-r ../assets/assets.zip .");
+        Utils.RunProcess(zip, workingDir: Path.Combine(OutputDir, "assets-tozip"), args: "-q -r ../assets/assets.zip .");
         Directory.Delete(Path.Combine(OutputDir, "assets-tozip"), true);
 
         if (!File.Exists(androidJar))

diff --git a/tools-local/tasks/mobile.tasks/AndroidAppBuilder/Utils.cs b/tools-local/tasks/mobile.tasks/AndroidAppBuilder/Utils.cs
@@ -26,7 +26,7 @@ public static string RunProcess(
         IDictionary<string, string>? envVars = null,
         string? workingDir = null,
         bool ignoreErrors = false,
-        bool silent = false)
+        bool silent = true)
     {
         LogInfo($"Running: {path} {args}");
         var outputBuilder = new StringBuilder();
@@ -52,16 +52,16 @@ public static string RunProcess(
 
         Process? process = Process.Start(processStartInfo);
         if (process == null)
-            throw new ArgumentException("Process.Start({path} {args}) returned null process");
+            throw new ArgumentException($"Process.Start({path} {args}) returned null process");
 
         process.ErrorDataReceived += (sender, e) =>
         {
             if (!silent)
             {
                 LogError(e.Data);
                 outputBuilder.AppendLine(e.Data);
-                errorBuilder.AppendLine(e.Data);
             }
+            errorBuilder.AppendLine(e.Data);
         };
         process.OutputDataReceived += (sender, e) =>
         {