Delete WebHeaderCollection's event source (dotnet#38871)

The logging is verbose, arbitrary, expensive, and duplicative of logging that happens when headers are actually read/written by the underlying networking stack. Delete.
waiyiptam · Jul 9, 2020 · bdfbf0c · bdfbf0c
1 parent 6eff584
commit bdfbf0c
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 43 deletions.
diff --git a/src/libraries/System.Net.WebHeaderCollection/src/System.Net.WebHeaderCollection.csproj b/src/libraries/System.Net.WebHeaderCollection/src/System.Net.WebHeaderCollection.csproj
@@ -11,7 +11,6 @@
     <Compile Include="System\Net\HttpRequestHeader.cs" />
     <Compile Include="System\Net\HeaderInfo.cs" />
     <Compile Include="System\Net\HeaderInfoTable.cs" />
-    <Compile Include="System\Net\NetEventSource.WebHeaderCollection.cs" />
     <Compile Include="$(CommonPath)System\Net\CaseInsensitiveAscii.cs"
              Link="Common\System\Net\CaseInsensitiveAscii.cs" />
     <Compile Include="$(CommonPath)System\StringExtensions.cs"
@@ -20,8 +19,6 @@
              Link="Common\System\Net\HttpKnownHeaderNames.cs" />
     <Compile Include="$(CommonPath)System\Net\HttpValidationHelpers.cs"
              Link="Common\System\Net\HttpValidationHelpers.cs" />
-    <Compile Include="$(CommonPath)System\Net\Logging\NetEventSource.Common.cs"
-             Link="Common\System\Net\Logging\NetEventSource.Common.cs" />
   </ItemGroup>
   <ItemGroup>
     <Reference Include="System.Collections" />

diff --git a/...aries/System.Net.WebHeaderCollection/src/System/Net/NetEventSource.WebHeaderCollection.cs b/...aries/System.Net.WebHeaderCollection/src/System/Net/NetEventSource.WebHeaderCollection.cs
diff --git a/src/libraries/System.Net.WebHeaderCollection/src/System/Net/WebHeaderCollection.cs b/src/libraries/System.Net.WebHeaderCollection/src/System/Net/WebHeaderCollection.cs
@@ -143,7 +143,6 @@ public override void Set(string name, string? value)
             name = HttpValidationHelpers.CheckBadHeaderNameChars(name);
             ThrowOnRestrictedHeader(name);
             value = HttpValidationHelpers.CheckBadHeaderValueChars(value);
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"calling InnerCollection.Set() key:[{name}], value:[{value}]");
             if (_type == WebHeaderCollectionType.WebResponse)
             {
                 if (value != null && value.Length > ushort.MaxValue)
@@ -372,7 +371,6 @@ public void Add(string header)
             name = HttpValidationHelpers.CheckBadHeaderNameChars(name);
             ThrowOnRestrictedHeader(name);
             value = HttpValidationHelpers.CheckBadHeaderValueChars(value);
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"Add({header}) calling InnerCollection.Add() key:[{name}], value:[{value}]");
             if (_type == WebHeaderCollectionType.WebResponse)
             {
                 if (value != null && value.Length > ushort.MaxValue)
@@ -400,7 +398,6 @@ public override void Add(string name, string? value)
             name = HttpValidationHelpers.CheckBadHeaderNameChars(name);
             ThrowOnRestrictedHeader(name);
             value = HttpValidationHelpers.CheckBadHeaderValueChars(value);
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"calling InnerCollection.Add() key:[{name}], value:[{value}]");
             if (_type == WebHeaderCollectionType.WebResponse)
             {
                 if (value != null && value.Length > ushort.MaxValue)
@@ -416,7 +413,6 @@ protected void AddWithoutValidate(string headerName, string? headerValue)
         {
             headerName = HttpValidationHelpers.CheckBadHeaderNameChars(headerName);
             headerValue = HttpValidationHelpers.CheckBadHeaderValueChars(headerValue);
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"calling InnerCollection.Add() key:[{headerName}], value:[{headerValue}]");
             if (_type == WebHeaderCollectionType.WebResponse)
             {
                 if (headerValue != null && headerValue.Length > ushort.MaxValue)
@@ -469,7 +465,6 @@ public override void Remove(string name)
             }
             ThrowOnRestrictedHeader(name);
             name = HttpValidationHelpers.CheckBadHeaderNameChars(name);
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"calling InnerCollection.Remove() key:[{name}]");
             if (_innerCollection != null)
             {
                 InvalidateCachedArrays();
@@ -512,7 +507,6 @@ public override string ToString()
             }
 
             sb.Append("\r\n");
-            if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"ToString: {sb}");
             return sb.ToString();
         }
 

diff --git a/src/libraries/System.Net.WebHeaderCollection/tests/LoggingTest.cs b/src/libraries/System.Net.WebHeaderCollection/tests/LoggingTest.cs
diff --git a/...ibraries/System.Net.WebHeaderCollection/tests/System.Net.WebHeaderCollection.Tests.csproj b/...ibraries/System.Net.WebHeaderCollection/tests/System.Net.WebHeaderCollection.Tests.csproj
@@ -4,6 +4,5 @@
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="WebHeaderCollectionTest.cs" />
-    <Compile Include="LoggingTest.cs" />
   </ItemGroup>
 </Project>