MDL-19698 deprecated assign new by ref in chat server - there are muc…

…h worse problems left I think
wakamori · Jul 19, 2010 · 0e7de62 · 0e7de62
1 parent e4361ed
commit 0e7de62
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/mod/chat/chatd.php b/mod/chat/chatd.php
@@ -283,7 +283,7 @@ function openpopup(url,name,options,fullscreen) {
 
             $link = '/user/view.php?id='.$userinfo['user']->id.'&course='.$userinfo['courseid'];
             $anchortagcontents = $OUTPUT->user_picture($userinfo['user'], array('courseid'=>$userinfo['courseid']));
-            
+
             $action = new popup_action('click', $link, 'user'.$userinfo['chatuser']->id);
             $anchortag = $OUTPUT->action_link($link, $anchortagcontents, $action);
 
@@ -335,7 +335,7 @@ function dispatch_sidekick($handle, $type, $sessionid, $customdata) {
         switch($type) {
             case CHAT_SIDEKICK_BEEP:
                 // Incoming beep
-                $msg = &New stdClass;
+                $msg = New stdClass;
                 $msg->chatid    = $this->sets_info[$sessionid]['chatid'];
                 $msg->userid    = $this->sets_info[$sessionid]['userid'];
                 $msg->groupid   = $this->sets_info[$sessionid]['groupid'];
@@ -421,7 +421,7 @@ function dispatch_sidekick($handle, $type, $sessionid, $customdata) {
                     $this->sets_info[$sessionid]['lastmessageindex'] = $messageindex;
                 }
 
-                $msg = &New stdClass;
+                $msg = New stdClass;
                 $msg->chatid    = $this->sets_info[$sessionid]['chatid'];
                 $msg->userid    = $this->sets_info[$sessionid]['userid'];
                 $msg->groupid   = $this->sets_info[$sessionid]['groupid'];
@@ -680,7 +680,7 @@ function conn_accept() {
             return false;
         }
 
-        $newconn = &New ChatConnection($handle);
+        $newconn = New ChatConnection($handle);
         $id = $this->new_ufo_id();
         $this->conn_ufo[$id] = $newconn;
 
@@ -753,7 +753,7 @@ function disconnect_session($sessionid) {
         $info = $this->sets_info[$sessionid];
 
         $DB->delete_records('chat_users', array('sid'=>$sessionid));
-        $msg = &New stdClass;
+        $msg = New stdClass;
         $msg->chatid = $info['chatid'];
         $msg->userid = $info['userid'];
         $msg->groupid = $info['groupid'];