MDL-20625 fixed transaction related todos

wakamori · Nov 8, 2009 · 6ccaf3f · 6ccaf3f
1 parent 088f3ff
commit 6ccaf3f
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/group/externallib.php b/group/externallib.php
@@ -239,8 +239,7 @@ public static function delete_groups($groupids) {
 
         $transaction = $DB->start_delegated_transaction();
 
-// TODO: this is problematic because the DB rollback does not handle deleting of images!!
-//       there is also potential problem with events propagating action to external systems :-(
+// TODO: this is problematic because the DB rollback does not handle deleting of group images!
         foreach ($params['groupids'] as $groupid) {
             // validate params
             $groupid = validate_param($groupid, PARAM_INTEGER);
@@ -354,7 +353,6 @@ public static function add_groupmembers($members) {
         $params = self::validate_parameters(self::add_groupmembers_parameters(), array('members'=>$members));
 
         $transaction = $DB->start_delegated_transaction();
-        // TODO: there is a potential problem with events propagating action to external systems :-(
         foreach ($params['members'] as $member) {
             // validate params
             $groupid = $member['groupid'];
@@ -419,7 +417,6 @@ public static function delete_groupmembers($members) {
 
         $transaction = $DB->start_delegated_transaction();
 
-// TODO: there is a potential problem with events propagating action to external systems :-(
         foreach ($params['members'] as $member) {
             // validate params
             $groupid = $member['groupid'];