MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_ke…

…y_types (matrix-org#12520) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog
wakira · Apr 22, 2022 · b82fff6 · b82fff6
1 parent f46b223
commit b82fff6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/12520.bugfix b/changelog.d/12520.bugfix
@@ -0,0 +1 @@
+Fix a bug in the implementation of MSC3202 where Synapse would use the field name `device_unused_fallback_keys`, rather than `device_unused_fallback_key_types`.
diff --git a/synapse/appservice/__init__.py b/synapse/appservice/__init__.py
@@ -42,7 +42,7 @@
 #   user ID -> {device ID -> {algorithm -> count}}
 TransactionOneTimeKeyCounts = Dict[str, Dict[str, Dict[str, int]]]
 
-# Type for the `device_unused_fallback_keys` field in an appservice transaction
+# Type for the `device_unused_fallback_key_types` field in an appservice transaction
 #   user ID -> {device ID -> [algorithm]}
 TransactionUnusedFallbackKeys = Dict[str, Dict[str, List[str]]]
 

diff --git a/synapse/appservice/api.py b/synapse/appservice/api.py
@@ -278,7 +278,7 @@ async def push_bulk(
                 ] = one_time_key_counts
             if unused_fallback_keys:
                 body[
-                    "org.matrix.msc3202.device_unused_fallback_keys"
+                    "org.matrix.msc3202.device_unused_fallback_key_types"
                 ] = unused_fallback_keys
             if device_list_summary:
                 body["org.matrix.msc3202.device_lists"] = {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix a bug in the implementation of MSC3202 where Synapse would use the field name `device_unused_fallback_keys`, rather than `device_unused_fallback_key_types`.