feat: incentivization POC: add double-spend check for txid-based eligibility #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
You can find the image built from this PR at Built from c142994 |
Ivansete-status
approved these changes
Jan 30, 2025
s-tikhomirov
force-pushed
the
feat/incentivization-poc-double-spend-check
branch
2 times, most recently
from
713e3f1 to
9ed1be7
Compare
jm-clius
approved these changes
Jan 31, 2025
s-tikhomirov
force-pushed
the
feat/incentivization-poc-double-spend-check
branch
from
9ed1be7 to
cd6d4d4
Compare
Co-authored-by: Ivan FB <[email protected]>
Co-authored-by: Ivan FB <[email protected]>
s-tikhomirov
force-pushed
the
feat/incentivization-poc-double-spend-check
branch
from
cd6d4d4 to
a5113c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a continuation of the work started in #3166 with associated deliverable waku-org/pm#245.
The overall task is to implement a proof-of-concept service incentivization mechanism, where clients submit txids alongside their requests, and servers check eligibility of those txids as proofs of payment.
This PR adds a check against double-spending. A client is prevented from submitting the same txid twice. The server keeps track of txids it has seen, and checks every txid against that set. If the txid is in the set, the eligibility check fails.
Note the assumption: a transaction once deemed ineligible will never become eligible in the future, even (for example) in a scenario where a transaction underpaid, and later the server decreased its prices. Such scenarios look too complicated for a PoC. For now, we assume that a server declares a transaction eligible or ineligible when it is first submitted as proof of payment. No matter the result of the initial check, the same txid will be ineligible on all future submissions.
Changes