[RFR] Complete lib #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
suggested changes
Apr 30, 2019
| const reservedByte = Buffer.from([0x00]); | ||
| const publicKey = convertCOSEPublicKeyToRawPKCSECDHAKey(authenticatorData.COSEPublicKey); | ||
| const publicKey = ConvertCOSEPublicKeyToRawPKCSECDHAKey( |
| ]); | ||
|
|
||
| const PEMCertificate = convertASN1toPEM(authenticatorKey.attStmt.x5c[0]); | ||
| const PEMCertificate = ConvertASN1toPEM(authenticatorKey.attStmt.x5c[0]); |
| ]); | ||
|
|
||
| const publicKey = convertASN1toPEM(Buffer.from(key.publicKey, 'base64')); | ||
| const publicKey = ConvertASN1toPEM(Buffer.from(key.publicKey, 'base64')); |
packages/server/src/utils.js
Outdated
|
|
||
| /** | ||
| * Convert binary certificate or public key to an OpenSSL-compatible PEM text format. | ||
| */ | ||
| exports.convertASN1toPEM = pkBuffer => { | ||
| exports.ConvertASN1toPEM = pkBuffer => { |
packages/server/src/utils.js
Outdated
| * @param {Buffer} cosePublicKey - COSE encoded public key | ||
| * @return {Buffer} - RAW PKCS encoded public key | ||
| */ | ||
| exports.ConvertCOSEPublicKeyToRawPKCSECDHAKey = cosePublicKey => { |
ThieryMichel
force-pushed
the
complete_lib
branch
from
4e8ce1a to
671ffc2
Compare
ThieryMichel
force-pushed
the
complete_lib
branch
from
671ffc2 to
6f4f119
Compare
djhi
approved these changes
Apr 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow #2