Skip to content

Commit

Permalink
Use WARN() in block/
Browse files Browse the repository at this point in the history
Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.

Signed-off-by: Arjan van de Ven <[email protected]>
Cc: Jens Axboe <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
fenrus75 authored and torvalds committed Jul 26, 2008
1 parent 261c40c commit 12e0036
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions block/as-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -837,8 +837,7 @@ static void as_completed_request(struct request_queue *q, struct request *rq)
WARN_ON(!list_empty(&rq->queuelist));

if (RQ_STATE(rq) != AS_RQ_REMOVED) {
printk("rq->state %d\n", RQ_STATE(rq));
WARN_ON(1);
WARN(1, "rq->state %d\n", RQ_STATE(rq));
goto out;
}

Expand Down

0 comments on commit 12e0036

Please sign in to comment.