Skip to content

Commit

Permalink
net: convert usage of packet_type to read_mostly
Browse files Browse the repository at this point in the history
Protocols that use packet_type can be __read_mostly section for better
locality. Elminate any unnecessary initializations of NULL.

Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Stephen Hemminger authored and davem330 committed Mar 10, 2009
1 parent 3f61213 commit 7546dd9
Show file tree
Hide file tree
Showing 21 changed files with 26 additions and 29 deletions.
2 changes: 1 addition & 1 deletion drivers/block/aoe/aoenet.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ aoenet_rcv(struct sk_buff *skb, struct net_device *ifp, struct packet_type *pt,
return 0;
}

static struct packet_type aoe_pt = {
static struct packet_type aoe_pt __read_mostly = {
.type = __constant_htons(ETH_P_AOE),
.func = aoenet_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/hamradio/bpqether.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ static char bpq_eth_addr[6];
static int bpq_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *);
static int bpq_device_event(struct notifier_block *, unsigned long, void *);

static struct packet_type bpq_packet_type = {
static struct packet_type bpq_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_BPQ),
.func = bpq_rcv,
};
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/pppoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -513,17 +513,17 @@ static int pppoe_disc_rcv(struct sk_buff *skb, struct net_device *dev,
return NET_RX_SUCCESS; /* Lies... :-) */
}

static struct packet_type pppoes_ptype = {
static struct packet_type pppoes_ptype __read_mostly = {
.type = cpu_to_be16(ETH_P_PPP_SES),
.func = pppoe_rcv,
};

static struct packet_type pppoed_ptype = {
static struct packet_type pppoed_ptype __read_mostly = {
.type = cpu_to_be16(ETH_P_PPP_DISC),
.func = pppoe_disc_rcv,
};

static struct proto pppoe_sk_proto = {
static struct proto pppoe_sk_proto __read_mostly = {
.name = "PPPOE",
.owner = THIS_MODULE,
.obj_size = sizeof(struct pppox_sock),
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wan/hdlc.c
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ EXPORT_SYMBOL(unregister_hdlc_protocol);
EXPORT_SYMBOL(attach_hdlc_protocol);
EXPORT_SYMBOL(detach_hdlc_protocol);

static struct packet_type hdlc_packet_type = {
static struct packet_type hdlc_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_HDLC),
.func = hdlc_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wan/lapbether.c
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ static int lapbeth_device_event(struct notifier_block *this,

/* ------------------------------------------------------------------------ */

static struct packet_type lapbeth_packet_type = {
static struct packet_type lapbeth_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_DEC),
.func = lapbeth_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/8021q/vlan.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const char vlan_version[] = DRV_VERSION;
static const char vlan_copyright[] = "Ben Greear <[email protected]>";
static const char vlan_buggyright[] = "David S. Miller <[email protected]>";

static struct packet_type vlan_packet_type = {
static struct packet_type vlan_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_8021Q),
.func = vlan_skb_recv, /* VLAN receive method */
};
Expand Down
4 changes: 2 additions & 2 deletions net/appletalk/ddp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1860,12 +1860,12 @@ static struct notifier_block ddp_notifier = {
.notifier_call = ddp_device_event,
};

static struct packet_type ltalk_packet_type = {
static struct packet_type ltalk_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_LOCALTALK),
.func = ltalk_rcv,
};

static struct packet_type ppptalk_packet_type = {
static struct packet_type ppptalk_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_PPPTALK),
.func = atalk_rcv,
};
Expand Down
3 changes: 1 addition & 2 deletions net/ax25/af_ax25.c
Original file line number Diff line number Diff line change
Expand Up @@ -1985,9 +1985,8 @@ static const struct proto_ops ax25_proto_ops = {
/*
* Called by socket.c on kernel start up
*/
static struct packet_type ax25_packet_type = {
static struct packet_type ax25_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_AX25),
.dev = NULL, /* All devices */
.func = ax25_kiss_rcv,
};

Expand Down
3 changes: 1 addition & 2 deletions net/decnet/af_decnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -2112,9 +2112,8 @@ static struct notifier_block dn_dev_notifier = {

extern int dn_route_rcv(struct sk_buff *, struct net_device *, struct packet_type *, struct net_device *);

static struct packet_type dn_dix_packet_type = {
static struct packet_type dn_dix_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_DNA_RT),
.dev = NULL, /* All devices */
.func = dn_route_rcv,
};

Expand Down
2 changes: 1 addition & 1 deletion net/dsa/tag_dsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ static int dsa_rcv(struct sk_buff *skb, struct net_device *dev,
return 0;
}

static struct packet_type dsa_packet_type = {
static struct packet_type dsa_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_DSA),
.func = dsa_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/dsa/tag_edsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ static int edsa_rcv(struct sk_buff *skb, struct net_device *dev,
return 0;
}

static struct packet_type edsa_packet_type = {
static struct packet_type edsa_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_EDSA),
.func = edsa_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/dsa/tag_trailer.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ static int trailer_rcv(struct sk_buff *skb, struct net_device *dev,
return 0;
}

static struct packet_type trailer_packet_type = {
static struct packet_type trailer_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_TRAILER),
.func = trailer_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/econet/af_econet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ static int econet_rcv(struct sk_buff *skb, struct net_device *dev, struct packet
return NET_RX_DROP;
}

static struct packet_type econet_packet_type = {
static struct packet_type econet_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_ECONET),
.func = econet_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/ipv4/af_inet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ static int ipv4_proc_init(void);
* IP protocol layer initialiser
*/

static struct packet_type ip_packet_type = {
static struct packet_type ip_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_IP),
.func = ip_rcv,
.gso_send_check = inet_gso_send_check,
Expand Down
2 changes: 1 addition & 1 deletion net/ipv4/arp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ void arp_ifdown(struct net_device *dev)
* Called once on startup.
*/

static struct packet_type arp_packet_type = {
static struct packet_type arp_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_ARP),
.func = arp_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/ipv6/af_inet6.c
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ static int ipv6_gro_complete(struct sk_buff *skb)
return err;
}

static struct packet_type ipv6_packet_type = {
static struct packet_type ipv6_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_IPV6),
.func = ipv6_rcv,
.gso_send_check = ipv6_gso_send_check,
Expand Down
4 changes: 2 additions & 2 deletions net/ipx/af_ipx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1958,12 +1958,12 @@ static const struct proto_ops SOCKOPS_WRAPPED(ipx_dgram_ops) = {

SOCKOPS_WRAP(ipx_dgram, PF_IPX);

static struct packet_type ipx_8023_packet_type = {
static struct packet_type ipx_8023_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_802_3),
.func = ipx_rcv,
};

static struct packet_type ipx_dix_packet_type = {
static struct packet_type ipx_dix_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_IPX),
.func = ipx_rcv,
};
Expand Down
2 changes: 1 addition & 1 deletion net/irda/irmod.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ EXPORT_SYMBOL(irda_debug);
/* Packet type handler.
* Tell the kernel how IrDA packets should be handled.
*/
static struct packet_type irda_packet_type = {
static struct packet_type irda_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_IRDA),
.func = irlap_driver_rcv, /* Packet type handler irlap_frame.c */
};
Expand Down
4 changes: 2 additions & 2 deletions net/llc/llc_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -147,12 +147,12 @@ void llc_sap_close(struct llc_sap *sap)
kfree(sap);
}

static struct packet_type llc_packet_type = {
static struct packet_type llc_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_802_2),
.func = llc_rcv,
};

static struct packet_type llc_tr_packet_type = {
static struct packet_type llc_tr_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_TR_802_2),
.func = llc_rcv,
};
Expand Down
3 changes: 1 addition & 2 deletions net/phonet/af_phonet.c
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,8 @@ static int phonet_rcv(struct sk_buff *skb, struct net_device *dev,
return NET_RX_DROP;
}

static struct packet_type phonet_packet_type = {
static struct packet_type phonet_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_PHONET),
.dev = NULL,
.func = phonet_rcv,
};

Expand Down
2 changes: 1 addition & 1 deletion net/x25/af_x25.c
Original file line number Diff line number Diff line change
Expand Up @@ -1608,7 +1608,7 @@ static const struct proto_ops SOCKOPS_WRAPPED(x25_proto_ops) = {

SOCKOPS_WRAP(x25_proto, AF_X25);

static struct packet_type x25_packet_type = {
static struct packet_type x25_packet_type __read_mostly = {
.type = cpu_to_be16(ETH_P_X25),
.func = x25_lapb_receive_frame,
};
Expand Down

0 comments on commit 7546dd9

Please sign in to comment.