See knockout#375. Allow spaces around "=" in data-bind attribute

wangsong · May 14, 2013 · 86a62bd · 86a62bd
1 parent 15da151
commit 86a62bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/spec/templatingBehaviors.js b/spec/templatingBehaviors.js
@@ -331,6 +331,12 @@ describe('Templating', function() {
         expect(testNode.childNodes[0].value).toEqual("hello");
     });
 
+    it('Should handle data-bind attributes with spaces around equals sign from inside templates and reference variables', function () {
+        ko.setTemplateEngine(new dummyTemplateEngine({ someTemplate: "<input data-bind = 'value:message' />" }));
+        ko.renderTemplate("someTemplate", null, { templateRenderingVariablesInScope: { message: "hello"} }, testNode);
+        expect(testNode.childNodes[0].value).toEqual("hello");
+    });
+
     it('Data binding syntax should be able to use $element in binding value', function() {
         ko.setTemplateEngine(new dummyTemplateEngine({ someTemplate: "<div data-bind='text: $element.tagName'></div>" }));
         ko.renderTemplate("someTemplate", null, null, testNode);

diff --git a/src/templating/templateRewriting.js b/src/templating/templateRewriting.js
@@ -1,6 +1,6 @@
 
 ko.templateRewriting = (function () {
-    var memoizeDataBindingAttributeSyntaxRegex = /(<([a-z]+\d*)(?:\s+(?!data-bind=)[a-z0-9\-]+(?:=(?:\"[^\"]*\"|\'[^\']*\'))?)*\s+)data-bind=(["'])([\s\S]*?)\3/gi;
+    var memoizeDataBindingAttributeSyntaxRegex = /(<([a-z]+\d*)(?:\s+(?!data-bind\s*=\s*)[a-z0-9\-]+(?:=(?:\"[^\"]*\"|\'[^\']*\'))?)*\s+)data-bind\s*=\s*(["'])([\s\S]*?)\3/gi;
     var memoizeVirtualContainerBindingSyntaxRegex = /<!--\s*ko\b\s*([\s\S]*?)\s*-->/g;
 
     function validateDataBindValuesForRewriting(keyValueArray) {