Skip to content

Commit

Permalink
can: af_can: rename find_dev_rcv_lists() to can_dev_rcv_lists_find()
Browse files Browse the repository at this point in the history
This patch add the commonly used prefix "can_" to the find_dev_rcv_lists()
function and moves the "find" to the end, as the function returns a struct
can_dev_rcv_list. This improves the overall readability of the code.

Signed-off-by: Oleksij Rempel <[email protected]>
Acked-by: Oliver Hartkopp <[email protected]>
Signed-off-by: Marc Kleine-Budde <[email protected]>
  • Loading branch information
marckleinebudde committed Sep 4, 2019
1 parent 3ee6d2b commit fac7850
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions net/can/af_can.c
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ EXPORT_SYMBOL(can_send);

/* af_can rx path */

static struct can_dev_rcv_lists *find_dev_rcv_lists(struct net *net,
struct net_device *dev)
static struct can_dev_rcv_lists *can_dev_rcv_lists_find(struct net *net,
struct net_device *dev)
{
if (!dev)
return net->can.rx_alldev_list;
Expand Down Expand Up @@ -458,7 +458,7 @@ int can_rx_register(struct net *net, struct net_device *dev, canid_t can_id,

spin_lock(&net->can.rcvlists_lock);

dev_rcv_lists = find_dev_rcv_lists(net, dev);
dev_rcv_lists = can_dev_rcv_lists_find(net, dev);
if (dev_rcv_lists) {
rl = can_rcv_list_find(&can_id, &mask, dev_rcv_lists);

Expand Down Expand Up @@ -526,7 +526,7 @@ void can_rx_unregister(struct net *net, struct net_device *dev, canid_t can_id,

spin_lock(&net->can.rcvlists_lock);

dev_rcv_lists = find_dev_rcv_lists(net, dev);
dev_rcv_lists = can_dev_rcv_lists_find(net, dev);
if (!dev_rcv_lists) {
pr_err("BUG: receive list not found for dev %s, id %03X, mask %03X\n",
DNAME(dev), can_id, mask);
Expand Down Expand Up @@ -671,7 +671,7 @@ static void can_receive(struct sk_buff *skb, struct net_device *dev)
matches = can_rcv_filter(net->can.rx_alldev_list, skb);

/* find receive list for this device */
dev_rcv_lists = find_dev_rcv_lists(net, dev);
dev_rcv_lists = can_dev_rcv_lists_find(net, dev);
if (dev_rcv_lists)
matches += can_rcv_filter(dev_rcv_lists, skb);

Expand Down

0 comments on commit fac7850

Please sign in to comment.