Merge pull request uptrace#43 from j2gg0s/mysql-insert-without-alias

insert: mysql does not support insert with alis
wangyuanzhao · Jun 30, 2021 · a0da3d0 · a0da3d0
2 parents f60ca22 + e65fc3a
commit a0da3d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/db.go b/db.go
@@ -486,6 +486,10 @@ func (db *DB) supportsDeleteTableAlias() bool {
 	return true
 }
 
+func (db *DB) supportsInsertTableAlias() bool {
+	return db.dialect.Name() != dialect.MySQL
+}
+
 func (db *DB) mysqlVersion() string {
 	db.mysql.versionOnce.Do(func() {
 		var version string

diff --git a/query_insert.go b/query_insert.go
@@ -161,7 +161,7 @@ func (q *InsertQuery) AppendQuery(fmter schema.Formatter, b []byte) (_ []byte, e
 	}
 	b = append(b, "INTO "...)
 
-	if !q.onConflict.IsZero() {
+	if !q.onConflict.IsZero() && q.db.supportsInsertTableAlias() {
 		b, err = q.appendFirstTableWithAlias(fmter, b)
 	} else {
 		b, err = q.appendFirstTable(fmter, b)