Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treatment of empty CLI args #9

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Fix treatment of empty CLI args #9

merged 2 commits into from
Jul 8, 2024

Conversation

frank-emrich
Copy link
Contributor

The harness was ignoring empty CLI arguments, treating them the same as if they were not given at all.
Meaning that the following were treated the same, even though they aren't

./harness run --wasmtime-cargo-build-args=""
./harness run

@frank-emrich frank-emrich requested a review from dhil July 5, 2024 10:37
Copy link
Member

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dhil dhil merged commit c0559fa into main Jul 8, 2024
2 checks passed
@dhil dhil deleted the harness-fix branch July 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants