Quote the alias in MySQL DELETE queries

watanaberin · Sep 25, 2023 · cd74248 · cd74248
1 parent 1a9c3bb
commit cd74248
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/pony/orm/sqlbuilding.py b/pony/orm/sqlbuilding.py
@@ -232,8 +232,9 @@ def DELETE(builder, alias, from_ast, where=None):
         builder.indent += 1
         if alias is not None:
             assert isinstance(alias, str)
-            if not where: return 'DELETE ', alias, ' ', builder(from_ast)
-            return 'DELETE ', alias, ' ', builder(from_ast), builder(where)
+            if not where:
+                return 'DELETE ', builder.quote_name(alias), ' ', builder(from_ast)
+            return 'DELETE ', builder.quote_name(alias), ' ', builder(from_ast), builder(where)
         else:
             assert from_ast[0] == 'FROM' and len(from_ast) == 2 and from_ast[1][1] == 'TABLE'
             alias = from_ast[1][0]

diff --git a/pony/orm/tests/queries.txt b/pony/orm/tests/queries.txt
@@ -754,7 +754,7 @@ WHERE "id" IN (
 
 MySQL:
 
-DELETE s FROM `student` `s`
+DELETE `s` FROM `student` `s`
   INNER JOIN `group` `group`
     ON `s`.`group` = `group`.`number`
 WHERE `group`.`dept` = 1
@@ -791,7 +791,7 @@ WHERE "ROWID" IN (
 
 MySQL:
 
-DELETE c FROM `course` `c`
+DELETE `c` FROM `course` `c`
   INNER JOIN `department` `department`
     ON `c`.`dept` = `department`.`number`
 WHERE `department`.`name` LIKE 'D%%'