ofproto-dpif-xlate: Fix memory leak in execute_controller_action.

commit df70a77 ("ofproto-dpif-xlate: Allow translating without side-effects.") created a memory leak by removing the dp_packet_delete statement in execute_controller_action that freed the earlier cloned packet. This commit restores this statement to the end of the method. Fixes: df70a77 ("ofproto-dpif-xlate: Allow translating without side-effects.") Signed-off-by: Ryan Moats <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
water0615 · Sep 20, 2016 · 3b4fff4 · 3b4fff4
1 parent 1388f0b
commit 3b4fff4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
@@ -3648,6 +3648,8 @@ execute_controller_action(struct xlate_ctx *ctx, int len,
         entry->controller.ofproto = ctx->xbridge->ofproto;
         entry->controller.am = am;
     }
+
+    dp_packet_delete(packet);
 }
 
 static void