Skip to content

Commit

Permalink
ovs-atomic: Remove atomic_uint64_t and atomic_int64_t.
Browse files Browse the repository at this point in the history
Some concern has been raised by Ben Pfaff that atomic_uint64_t may not
be portable. In particular on 32bit platforms that do not have atomic
64bit integers.

Now that there are no longer any users of atomic_uint64_t remove it
entirely. Also remove atomic_int64_t which has no users.

Cc: YAMAMOTO Takashi <[email protected]>
Signed-off-by: Simon Horman <[email protected]>
Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
horms authored and blp committed May 16, 2014
1 parent 0e2a9f6 commit e09d61c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions lib/ovs-atomic.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,6 @@
* int8_t atomic_int8_t (*)
* int16_t atomic_int16_t (*)
* int32_t atomic_int32_t (*)
* uint64_t atomic_uint64_t (*)
* int64_t atomic_int64_t (*)
*
* (*) Not specified by C11.
*
Expand Down Expand Up @@ -296,12 +294,10 @@ typedef ATOMIC(uintptr_t) atomic_uintptr_t;
typedef ATOMIC(uint8_t) atomic_uint8_t;
typedef ATOMIC(uint16_t) atomic_uint16_t;
typedef ATOMIC(uint32_t) atomic_uint32_t;
typedef ATOMIC(uint64_t) atomic_uint64_t;

typedef ATOMIC(int8_t) atomic_int8_t;
typedef ATOMIC(int16_t) atomic_int16_t;
typedef ATOMIC(int32_t) atomic_int32_t;
typedef ATOMIC(int64_t) atomic_int64_t;

/* Reference count. */
struct ovs_refcount {
Expand Down
2 changes: 0 additions & 2 deletions tests/test-atomic.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ test_atomic_main(int argc OVS_UNUSED, char *argv[] OVS_UNUSED)
TEST_ATOMIC_TYPE(atomic_int16_t, int16_t);
TEST_ATOMIC_TYPE(atomic_uint32_t, uint32_t);
TEST_ATOMIC_TYPE(atomic_int32_t, int32_t);
TEST_ATOMIC_TYPE(atomic_uint64_t, uint64_t);
TEST_ATOMIC_TYPE(atomic_int64_t, int64_t);

test_atomic_flag();
}
Expand Down

0 comments on commit e09d61c

Please sign in to comment.