Also return ErrUnknownFileType for directories

waterschen · Jul 3, 2018 · 9e625b3 · 9e625b3
1 parent 58f22cc
commit 9e625b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/util/examples_test.go b/util/examples_test.go
@@ -164,7 +164,9 @@ func ExampleRun() {
 
 	// Create a simple test script
 	filename := "test-script"
-	script := "#!/bin/bash\necho -n Happy Hour"
+	script := `#!/bin/bash
+	echo -n Happy Hour
+	`
 
 	// Make sure script is executable!
 	if err := ioutil.WriteFile(filename, []byte(script), 0700); err != nil {

diff --git a/util/scripts.go b/util/scripts.go
@@ -12,7 +12,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"errors"
-	"fmt"
 	"log"
 	"os"
 	"os/exec"
@@ -107,7 +106,7 @@ func (rs Runners) Run(filename string, args ...string) ([]byte, error) {
 		return nil, err
 	}
 	if fi.IsDir() {
-		return nil, fmt.Errorf("%s is a directory", filename)
+		return nil, ErrUnknownFileType
 	}
 
 	// See if a runner will accept file