Reland of "Store a PhysicalNaturalSizingInfo in LayoutImage" #50291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the current `natural_size_` PhysicalSize to include also the natural aspect ratio. Due to the dependency from LayoutVideo, it is also updated to store its own natural dimensions rather than caching the poster image dimensions. Use the natural dimensions in LayoutImage to handle the call to IncrementVisuallyNonEmptyPixelCount() directly rather than calling LayoutImageResource::ImageSize(). This eliminates the last caller of LayoutImageResource::ImageSize(), so remove it. Reland update: Fix LayoutImage natural dimensions for the "represents nothing" case. If the LayoutImage had no image associated and got an ImageChanged() notification due to other reasons then it would compute to no natural dimensions. Set the natural dimensions to 0x0 in this case instead. Bug: 41357911, 40866163 Change-Id: Icc8ed20cef1c2398a1d25ac7a4b58132327916d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198418 Commit-Queue: Fredrik Söderquist <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1411544}
wpt-pr-bot
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the current
natural_size_PhysicalSize to include also thenatural aspect ratio. Due to the dependency from LayoutVideo, it is also
updated to store its own natural dimensions rather than caching the
poster image dimensions.
Use the natural dimensions in LayoutImage to handle the call to
IncrementVisuallyNonEmptyPixelCount() directly rather than calling
LayoutImageResource::ImageSize(). This eliminates the last caller of
LayoutImageResource::ImageSize(), so remove it.
Reland update: Fix LayoutImage natural dimensions for the "represents
nothing" case. If the LayoutImage had no image associated and got an
ImageChanged() notification due to other reasons then it would compute
to no natural dimensions. Set the natural dimensions to 0x0 in this case
instead.
Bug: 41357911, 40866163
Change-Id: Icc8ed20cef1c2398a1d25ac7a4b58132327916d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6198418
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1411544}