Translator: Switch to ModelStreamingResponder #50347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches to ModelStreamingResponder in preparation for implementing the translateStreaming. Some side effects of switching to ModelStreamingResponder is that: - We'll now be collecting metrics on the translator's response status, size, and count. - The signal option is now fully implemented for translate. Added a WPT to test. Bug: 380756385 Change-Id: Idcf126839a732af9ad9bd499a095d86e68e2a6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197550 Reviewed-by: Matthew Denton <[email protected]> Commit-Queue: Nathan Memmott <[email protected]> Cr-Commit-Position: refs/heads/main@{#1412529}
wpt-pr-bot
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to ModelStreamingResponder in preparation for implementing the
translateStreaming.
Some side effects of switching to ModelStreamingResponder is that:
size, and count.
to test.
Bug: 380756385
Change-Id: Idcf126839a732af9ad9bd499a095d86e68e2a6ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6197550
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Nathan Memmott <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1412529}