Provide layer bounds for text-shadow rendering #50415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lower layers have trouble culling away the shadows (and/or overestimate their bounds) which lead to high raster costs. Pass the computed visual rect for the text fragment when setting up the layer for the shadow. This appears to reduce the raster cost significantly in the case described in the bug. Add a physical version of InkOverflow::ExpandForShadowOverflow and simplify the application of the text-shadow ink overflow contribution. This also fixes an issue where the ink overflow was miscalculated for the vertical-lr writing mode. Guard with the flag "TextShadowPaintingOptimization". Bug: 391914237 Change-Id: I847d0a8291150ec1a92d4e7424c3a09eeecca134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6213771 Commit-Queue: Fredrik Söderquist <[email protected]> Reviewed-by: Stephen Chenney <[email protected]> Cr-Commit-Position: refs/heads/main@{#1414139}
wpt-pr-bot
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower layers have trouble culling away the shadows (and/or overestimate
their bounds) which lead to high raster costs.
Pass the computed visual rect for the text fragment when setting up the
layer for the shadow. This appears to reduce the raster cost
significantly in the case described in the bug.
Add a physical version of InkOverflow::ExpandForShadowOverflow and
simplify the application of the text-shadow ink overflow contribution.
This also fixes an issue where the ink overflow was miscalculated for
the vertical-lr writing mode.
Guard with the flag "TextShadowPaintingOptimization".
Bug: 391914237
Change-Id: I847d0a8291150ec1a92d4e7424c3a09eeecca134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6213771
Commit-Queue: Fredrik Söderquist <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1414139}