streaming without a wrapper, compile time JSX validation

webblocksapp · Jan 11, 2023 · a572c12 · a572c12
1 parent 19e6379
commit a572c12
Show file tree

Hide file tree

Showing 5 changed files with 619 additions and 410 deletions.
diff --git a/.changeset/cyan-plants-give.md b/.changeset/cyan-plants-give.md
@@ -0,0 +1,6 @@
+---
+"babel-preset-solid": patch
+"solid-js": patch
+---
+
+Streaming without a wrapper and compile time JSX validation
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
   },
   "devDependencies": {
     "@babel/cli": "^7.18.9",
-    "@babel/core": "^7.18.9",
+    "@babel/core": "^7.20.12",
     "@babel/preset-env": "^7.18.9",
     "@babel/preset-typescript": "^7.18.6",
     "@changesets/cli": "^2.25.2",
@@ -33,16 +33,16 @@
     "@types/jest": "^28.1.6",
     "@types/node": "^18.0.6",
     "babel-jest": "^28.1.3",
-    "babel-plugin-jsx-dom-expressions": "^0.35.10",
+    "babel-plugin-jsx-dom-expressions": "^0.35.13",
     "coveralls": "^3.1.1",
     "csstype": "^3.1.0",
-    "dom-expressions": "0.35.11",
+    "dom-expressions": "0.35.13",
     "fast-glob": "^3.2.11",
-    "hyper-dom-expressions": "0.35.11",
+    "hyper-dom-expressions": "0.35.13",
     "jest": "^28.1.3",
     "jest-environment-jsdom": "^28.1.3",
     "jest-ts-webcompat-resolver": "^1.0.0",
-    "lit-dom-expressions": "0.35.11",
+    "lit-dom-expressions": "0.35.13",
     "ncp": "^2.0.0",
     "npm-run-all": "^4.1.5",
     "rimraf": "^3.0.2",

diff --git a/packages/babel-preset-solid/package.json b/packages/babel-preset-solid/package.json
@@ -14,7 +14,7 @@
     "test": "node test.js"
   },
   "dependencies": {
-    "babel-plugin-jsx-dom-expressions": "^0.35.10"
+    "babel-plugin-jsx-dom-expressions": "^0.35.13"
   },
   "peerDependencies": {
     "@babel/core": "^7.0.0"

diff --git a/packages/solid/src/server/rendering.ts b/packages/solid/src/server/rendering.ts
@@ -601,7 +601,7 @@ export function Suspense(props: { fallback?: string; children: string }) {
   done = ctx.async ? ctx.registerFragment(id) : undefined;
   if (ctx.async) {
     setHydrateContext({ ...ctx, count: 0, id: ctx.id + "0.f", noHydrate: true });
-    const res = { t: `<span id="pl-${id}">${resolveSSRNode(props.fallback)}</span>` };
+    const res = { t: `<template id="pl-${id}"></template>${resolveSSRNode(props.fallback)}<!pl-${id}>` };
     setHydrateContext(ctx);
     return res;
   }