Coding style: consistent naming, one name per abstraction

Instead of having visible and visibility and setToolboxVisible and setFilmstripVisibility, have only visible as a name.
webboyvc · Feb 5, 2018 · aa314c1 · aa314c1
1 parent 62c9762
commit aa314c1
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 17 deletions.
diff --git a/modules/UI/videolayout/Filmstrip.js b/modules/UI/videolayout/Filmstrip.js
@@ -1,6 +1,6 @@
 /* global $, APP, interfaceConfig */
 
-import { setFilmstripVisibility } from '../../../react/features/filmstrip';
+import { setFilmstripVisible } from '../../../react/features/filmstrip';
 
 import UIEvents from '../../../service/UI/UIEvents';
 import UIUtil from '../util/UIUtil';
@@ -183,7 +183,7 @@ const Filmstrip = {
                 UIEvents.TOGGLED_FILMSTRIP,
                 !wasFilmstripVisible);
         }
-        APP.store.dispatch(setFilmstripVisibility(!wasFilmstripVisible));
+        APP.store.dispatch(setFilmstripVisible(!wasFilmstripVisible));
     },
 
     /**

diff --git a/react/features/filmstrip/actionTypes.js b/react/features/filmstrip/actionTypes.js
@@ -1,5 +1,5 @@
 /**
- * The type of the action which sets whether or not the filmstrip is being
+ * The type of (redux) action which sets whether or not the filmstrip is being
  * hovered with the cursor.
  *
  * {
@@ -10,11 +10,11 @@
 export const SET_FILMSTRIP_HOVERED = Symbol('SET_FILMSTRIP_HOVERED');
 
 /**
- * The type of action sets the visibility of the entire filmstrip.
+ * The type of (redux) action which sets the visibility of the filmstrip.
  *
  * {
- *     type: SET_FILMSTRIP_VISIBILITY,
+ *     type: SET_FILMSTRIP_VISIBLE,
  *     visible: boolean
  * }
  */
-export const SET_FILMSTRIP_VISIBILITY = Symbol('SET_FILMSTRIP_VISIBILITY');
+export const SET_FILMSTRIP_VISIBLE = Symbol('SET_FILMSTRIP_VISIBLE');
diff --git a/react/features/filmstrip/actions.js b/react/features/filmstrip/actions.js
@@ -1,6 +1,6 @@
 import {
     SET_FILMSTRIP_HOVERED,
-    SET_FILMSTRIP_VISIBILITY
+    SET_FILMSTRIP_VISIBLE
 } from './actionTypes';
 
 /**
@@ -21,17 +21,17 @@ export function setFilmstripHovered(hovered) {
 }
 
 /**
- * Sets if the entire filmstrip should be visible.
+ * Sets if the filmstrip should be visible.
  *
- * @param {boolean} visible - Whether not the filmstrip is visible.
+ * @param {boolean} visible - Whether the filmstrip should be visible.
  * @returns {{
- *     type: SET_FILMSTRIP_VISIBILITY,
+ *     type: SET_FILMSTRIP_VISIBLE,
  *     visible: boolean
  * }}
  */
-export function setFilmstripVisibility(visible) {
+export function setFilmstripVisible(visible) {
     return {
-        type: SET_FILMSTRIP_VISIBILITY,
+        type: SET_FILMSTRIP_VISIBLE,
         visible
     };
 }
diff --git a/react/features/filmstrip/reducer.js b/react/features/filmstrip/reducer.js
@@ -1,8 +1,6 @@
 import { ReducerRegistry } from '../base/redux';
-import {
-    SET_FILMSTRIP_HOVERED,
-    SET_FILMSTRIP_VISIBILITY
-} from './actionTypes';
+
+import { SET_FILMSTRIP_HOVERED, SET_FILMSTRIP_VISIBLE } from './actionTypes';
 
 const DEFAULT_STATE = {
     visible: true
@@ -18,7 +16,7 @@ ReducerRegistry.register(
                 hovered: action.hovered
             };
 
-        case SET_FILMSTRIP_VISIBILITY:
+        case SET_FILMSTRIP_VISIBLE:
             return {
                 ...state,
                 visible: action.visible