fix: Floating panel and dialog bugs #4708
Open
+135
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Jan 5, 2025
| @@ -92,7 +92,7 @@ export const ValueEditorDialog = ({ | |||
| title="CSS Value" | |||
| placement="bottom" | |||
| height={200} | |||
| width={Number(rawTheme.sizes.sidebarWidth)} | |||
| width={parseFloat(rawTheme.sizes.sidebarWidth)} | |||
There was a problem hiding this comment.
Let's take both Number.parseFloat
TrySound
reviewed
Jan 5, 2025
Comment on lines
+97
to
+99
| onResizeStart?: (entries: Array<ResizeObserverEntry>) => void; | ||
| onResize?: (entries: Array<ResizeObserverEntry>) => void; | ||
| onResizeEnd?: (entries: Array<ResizeObserverEntry>) => void; |
There was a problem hiding this comment.
I was in the middle of refactoring and used them, then removed the usage, thought its still useful potentially since the utility is generic.
johnsicili
requested changes
Jan 5, 2025
There was a problem hiding this comment.
1. Bindings open in middle
- Select an instance on the canvas
- Next click, open a binding
- See it in the middle of the page
Bindings open in unpredictable spots often. Will need to test this a lot
bindingrel.mp4
2. Style panel scroll with open dialog
- Open complex value
- Scroll style panel
- Click or drag dialog
- See jump
scrollst.mp4
Let me review again once these are fixed. These are super error prone and unpredictable IMO and we need to be careful with them. From a user perspective, they've caused my harm than help as of now.
|
@johnsicili seems like deployment didn't go through, you tested some buggy version |
|
second issue is valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile