Skip to content

Commit

Permalink
Small pgo cleanup (dotnet#48145)
Browse files Browse the repository at this point in the history
On the runtime side, intitialize the schema field so that the jit does not
internally think all optimized builds have pgo data with mismatched IL.

Quiet down some of the jit dumping when doing edge instrumentation.

Remove a few unused COMPlus vars from the jit.
  • Loading branch information
AndyAyersMS authored Feb 11, 2021
1 parent acdb869 commit cb5431d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
3 changes: 0 additions & 3 deletions src/coreclr/jit/fgprofile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -904,17 +904,14 @@ class EfficientEdgeCountInstrumentor : public Instrumentor, public SpanningTreeV
{
m_blockCount++;
block->bbSparseProbeList = nullptr;
JITDUMP("node " FMT_BB "\n", block->bbNum);
}

void VisitTreeEdge(BasicBlock* source, BasicBlock* target) override
{
JITDUMP("tree " FMT_BB " -> " FMT_BB "\n", source->bbNum, target->bbNum);
}

void VisitNonTreeEdge(BasicBlock* source, BasicBlock* target, SpanningTreeVisitor::EdgeKind kind) override
{
JITDUMP("non-tree " FMT_BB " -> " FMT_BB "\n", source->bbNum, target->bbNum);
switch (kind)
{
case EdgeKind::PostdominatesSource:
Expand Down
2 changes: 0 additions & 2 deletions src/coreclr/jit/jitconfigvalues.h
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,7 @@ CONFIG_INTEGER(JitEnableGuardedDevirtualization, W("JitEnableGuardedDevirtualiza
#if defined(DEBUG)
// Various policies for GuardedDevirtualization
CONFIG_STRING(JitGuardedDevirtualizationRange, W("JitGuardedDevirtualizationRange"))
CONFIG_INTEGER(JitGuardedDevirtualizationGuessUniqueInterface, W("JitGuardedDevirtualizationGuessUniqueInterface"), 1)
CONFIG_INTEGER(JitGuardedDevirtualizationGuessBestClass, W("JitGuardedDevirtualizationGuessBestClass"), 1)
CONFIG_INTEGER(JitGuardedDeivrtualizationUseProfile, W("JitGuardedDevirtualizationUseProfile"), 0)
#endif // DEBUG

// Enable insertion of patchpoints into Tier0 methods with loops.
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/vm/jitinterface.h
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ protected :
ComputedPgoData* m_next = nullptr;
MethodDesc *m_pMD;
NewArrayHolder<BYTE> m_allocatedData;
PgoInstrumentationSchema* m_schema;
PgoInstrumentationSchema* m_schema = nullptr;
UINT32 m_cSchemaElems;
BYTE *m_pInstrumentationData = nullptr;
HRESULT m_hr = E_NOTIMPL;
Expand Down

0 comments on commit cb5431d

Please sign in to comment.