Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise articles #75

Merged
merged 7 commits into from
Oct 15, 2018
Merged

Revise articles #75

merged 7 commits into from
Oct 15, 2018

Conversation

borntofrappe
Copy link
Contributor

I've tried to improve the wording of a few sentences which I thought could use a revision.

Let me know if there is some value to the changes I've made, as I plan to go through all markdown files. They are quite inspiring.

One last note: in the file "05 - Is var Dead? What should I use?.md" the link toward Kyle Simpson's opinion doesn't seem to forward toward an actual blog post. I've looked around, but all I could find was a video on frontendmasters, loosely related to the subject.

Re-write the two sentences expressing how including a global variable `name` might cause issues.
Include a sentence which possibly closes the article more clearly.
when highlighting the entire statement the wording is a tad confusing
pending issue: the link toward [Kyle Simpson's opinion](http://blog.getify.com/constantly-confusing-const/) doesn't actually forward a blog post. The closes match I could find with a quick search is [this URL](https://frontendmasters.com/courses/es6-right-parts/let-vs-var/), but it describes a video on the subject, and not a blog post.
try to simplify a few sentences possibly overly-complicated
break complex sentences in simpler lines
Backticks added (hopefully) only when needed
@wesbos wesbos merged commit badcfa4 into wesbos:master Oct 15, 2018
@wesbos
Copy link
Owner

wesbos commented Oct 15, 2018

thank you :)

Looks like Kyle Simpson's website is dead :(

@borntofrappe borntofrappe deleted the revise-ar branch October 15, 2018 19:50
@borntofrappe
Copy link
Contributor Author

A bit of a pity. Luckily the article details the main point behind the blog post.

And thank you for the opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants