Skip to content

Commit

Permalink
Language (SAP#93)
Browse files Browse the repository at this point in the history
* Markdown lint changes

* work on some wording towards ABAP
  • Loading branch information
thomham authored and HrFlorianHoffmann committed Sep 18, 2019
1 parent c6629e6 commit 8fad643
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions clean-abap/CleanABAP.md
Original file line number Diff line number Diff line change
Expand Up @@ -1859,9 +1859,8 @@ CLASS-METHODS describe_by_object_ref IMPORTING object_ref TYPE REF TO object [..
CLASS-METHODS describe_by_data_ref IMPORTING data_ref TYPE REF TO data [...]
```

Don't try to "remedy" ABAP's missing support for
[overloading](https://en.wikipedia.org/wiki/Function_overloading)
by adding optional parameters.
ABAP does not support [overloading](https://en.wikipedia.org/wiki/Function_overloading).
Use name variations and not optional parameters to achieve the desired semantics.

```ABAP
" anti-pattern
Expand Down Expand Up @@ -2153,9 +2152,7 @@ METHODS do_one_thing IMPORTING what_i_need TYPE string.
METHODS do_another_thing IMPORTING something_else TYPE i.
```

instead of trying to compensate ABAP's missing support for
[overloading](https://en.wikipedia.org/wiki/Function_overloading)
by adding optional parameters
to achieve the desired semantic as ABAP does not support [overloading](https://en.wikipedia.org/wiki/Function_overloading).

```ABAP
" anti-pattern
Expand Down

0 comments on commit 8fad643

Please sign in to comment.