fixed crash issue in no content-type situation.

whhh233 · Mar 14, 2020 · 98715e5 · 98715e5
1 parent 9fbbedd
commit 98715e5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/Proxy.js b/Proxy.js
@@ -216,7 +216,8 @@ let Proxy = ({urlModify, httpprefix, serverName, port, cookieDomainRewrite, loca
                 // res.status(404).send(`{"error": "${e}"}`)
                 return
             }
-            if (proxyRes.headers["content-type"].indexOf('text/') !== -1 ||
+            if (!proxyRes.headers["content-type"] ||
+                proxyRes.headers["content-type"].indexOf('text/') !== -1 ||
                 proxyRes.headers["content-type"].indexOf('javascript') !== -1 ||
                 proxyRes.headers["content-type"].indexOf('urlencoded') !== -1 ||
                 proxyRes.headers["content-type"].indexOf('json') !== -1) {

diff --git a/test/siteproxylocal.test.js b/test/siteproxylocal.test.js
@@ -251,3 +251,17 @@ test('youtube homepage issue', async () => {
 // h2020-03-13T23:24:08.403097+00:00 app[web.1]: httpType:https, host:id.google.com
 
 
+
+test('no content-type field situation', async () => {
+  const url = `${httpprefix}://${serverName}:${port}/https/onetag-sys.com/usync/?pubId=5927d926323dc2c`
+  const response = await axios({
+    method: 'get',
+    headers: {
+        'Accept': `text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.9`,
+    },
+    url,
+  })
+  // console.log(`${JSON.stringify(response.headers)}`)
+  // console.log(`${response.data}`)
+  expect(typeof(response.data)).toBe('object')
+}, 15000); // should be done within 3 seconds.