Bug in GF(2^n) bit generation with covert security (active security n…

…ot implemented).
white8boy · Sep 12, 2018 · 216eb0a · 216eb0a
1 parent 72d0c71
commit 216eb0a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/FHEOffline/CutAndChooseMachine.h b/FHEOffline/CutAndChooseMachine.h
@@ -19,6 +19,8 @@ class CutAndChooseMachine : public MultiplicativeMachine
 
 public:
     CutAndChooseMachine(int argc, const char** argv);
+
+    int get_covert() const { return sec; }
 };
 
 #endif /* FHEOFFLINE_CUTANDCHOOSEMACHINE_H_ */
diff --git a/FHEOffline/Producer.cpp b/FHEOffline/Producer.cpp
@@ -514,6 +514,8 @@ gf2nBitProducer::gf2nBitProducer(const Player& P, const FHE_PK& pk, int covert,
         Producer<P2Data>(thread_num, write_output),
         write_output(write_output), ECB(P, pk, covert, Bits)
 {
+    if (covert == 0)
+        throw not_implemented();
     this->dir = dir;
     if (write_output)
         open_prep_file<gf2n_short>(outf, data_type(), P.my_num(), thread_num,

diff --git a/FHEOffline/SimpleGenerator.cpp b/FHEOffline/SimpleGenerator.cpp
@@ -32,7 +32,7 @@ SimpleGenerator<T,FD>::SimpleGenerator(const Names& N, const PartSetup<FD>& setu
                     thread_num, machine.output);
             break;
         case DATA_BIT:
-            producer = new_bit_producer(setup.FieldD, P, setup.pk, 0, true,
+            producer = new_bit_producer(setup.FieldD, P, setup.pk, machine.get_covert(), true,
                     thread_num, machine.output);
             break;
         case DATA_INVERSE:

diff --git a/FHEOffline/SimpleMachine.h b/FHEOffline/SimpleMachine.h
@@ -59,6 +59,11 @@ class MultiplicativeMachine : public MachineBase
     void generate_setup(int slack);
     template <class FD>
     void fake_keys(int slack);
+
+public:
+    virtual ~MultiplicativeMachine() {}
+
+    virtual int get_covert() const { return 0; }
 };
 
 class SimpleMachine : public MultiplicativeMachine