Supported presenting modals in queues and added code documentation

[lurui1029]

No description provided.

[lucaslt89]

shouldn't this also have an onDismiss?: () => void type?

[lurui1029]

good catch!

[lucaslt89]

and then this one should be the one with dismiss: ModalDismissFunc right?

[lucaslt89]

these two blocks are similar, can we rewrite this as follows?

const dismissModal = () => {
  rootSiblings.destroy();
  rootSiblings = null;
  options?.onDismiss?.();
  onDismissForQueue?.();
  onDismiss?.();
}

if (ref) {
  ref.animatedOut(() => {
    ref = null;
    dismissModal();
  });
} else {
  console.warn('Dismissing a modal without animation because ref has been lost.');
  dismissModal();
}

[lurui1029]

makes sense. I'll apply your suggestion.

[lucaslt89]

can be changed to Math.max(modal.delay ?? this.minimumDelay) since this.minimumDelay will always be > 0

[lurui1029]

minimumDelay is 0 by default but users can change it to any other value. We need to add value verification to the minimumDelay's setter, or leave this as is.

[lucaslt89]

ahhhh ok, let's leave this as is then!

[lucaslt89]

I think this can also be simplified as just

await (new Promise<void>(resolve => setTimeout(resolve => modal.present(resolve), finalDelay)));

[lurui1029]

both setTimeout and new Promise creates async blocks (for setTimeout, even though the value is 0), so we can reduce this if finalDelay is 0.

[lucaslt89]

makes sense, let's leave it as it is then

[lucaslt89]

This onDismiss? shouldn't be a function that receives a function, it should be the function itself:

onDismiss?: () => void;