Skip to content

Commit

Permalink
fix: remove SuccessMessageMixin.form_valid violation of Liskov substi…
Browse files Browse the repository at this point in the history
…tution principle (typeddjango#84)
  • Loading branch information
antonagestam authored and mkurnikov committed Jun 2, 2019
1 parent 0e60b70 commit 629ba95
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions django-stubs/contrib/messages/views.pyi
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from typing import Any, Dict, Optional

from django.forms.forms import Form
from django.forms.forms import BaseForm
from django.http.response import HttpResponseRedirect

class SuccessMessageMixin:
success_message: str = ...
def form_valid(self, form: Form) -> HttpResponseRedirect: ...
def form_valid(self, form: BaseForm) -> HttpResponseRedirect: ...
def get_success_message(self, cleaned_data: Dict[str, str]) -> str: ...

0 comments on commit 629ba95

Please sign in to comment.