ctdb-scripts: Avoid shellcheck warning SC2015 (A && B || C)

SC2015: Note that A && B || C is not if-then-else. C may run when A is true. Signed-off-by: Martin Schwenke <[email protected]> Reviewed-by: Amitay Isaacs <[email protected]>
whyshan · Jul 21, 2016 · b0c1dbf · b0c1dbf
1 parent 987fd07
commit b0c1dbf
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/ctdb/config/ctdb.init b/ctdb/config/ctdb.init
@@ -95,6 +95,9 @@ stop()
 	redhat)
 	    "$ctdbd_wrapper" "$pidfile" "stop"
 	    RETVAL=$?
+	    # Common idiom in Red Hat init scripts - success() always
+	    # succeeds so this does behave like if-then-else
+	    # shellcheck disable=SC2015
             [ $RETVAL -eq 0 ] && success || failure
 	    echo ""
 	    [ $RETVAL -eq 0 ] && rm -f /var/lock/subsys/ctdb