I set preload to auto just before playing the video (fixes MailOnline#41

)
widespace-os · Sep 15, 2015 · 38309a6 · 38309a6
1 parent 629feb3
commit 38309a6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/demo/scripts/main.js b/demo/scripts/main.js
@@ -157,7 +157,7 @@ dom.onReady(function() {
     }
 
     function createVideoEl(container, cb) {
-      var videoTag = '<video class="video-js vjs-default-skin" controls preload="auto" poster="http://video-js.zencoder.com/oceans-clip.png" >' +
+      var videoTag = '<video class="video-js vjs-default-skin" controls preload="none" poster="http://video-js.zencoder.com/oceans-clip.png" >' +
         '<source src="http://video-js.zencoder.com/oceans-clip.mp4" type="video/mp4"/>' +
         '<source src="http://video-js.zencoder.com/oceans-clip.webm" type="video/webm"/>' +
         '<source src="http://video-js.zencoder.com/oceans-clip.ogv" type="video/ogg"/>' +
@@ -174,4 +174,4 @@ dom.onReady(function() {
       }, 0);
     }
   }
-});
+});
diff --git a/src/ads/vast/client/VASTIntegrator.js b/src/ads/vast/client/VASTIntegrator.js
@@ -287,6 +287,7 @@ VASTIntegrator.prototype._addClickThrough = function addClickThrough(mediaFile,
 VASTIntegrator.prototype._playSelectedAd = function playSelectedAd(source, response, callback) {
   var player = this.player;
 
+  player.preload("auto"); //without preload=auto the durationchange event is never fired
   player.src(source);
 
   playerUtils.once(player, ['durationchange', 'error', 'vast.adsCancel'], function (evt) {
@@ -321,4 +322,3 @@ VASTIntegrator.prototype._playSelectedAd = function playSelectedAd(source, respo
 VASTIntegrator.prototype._trackError = function trackError(error, response) {
   vastUtil.track(response.errorURLMacros, {ERRORCODE: error.code || 900});
 };
-
diff --git a/test/ads/vast/client/VASTIntegrator.spec.js b/test/ads/vast/client/VASTIntegrator.spec.js
@@ -61,6 +61,16 @@ describe("VASTIntegrator", function () {
         assertError(callback, 'On VASTIntegrator, missing required VASTResponse');
       });
 
+      it("must set preload to auto", function () {
+        // without preload=auto the durationchange event is never fired
+        var response = new VASTResponse();
+        var mediaFile = createMediaFile('http://foo.video.url.mp4', 'video/mp4');
+        response._addMediaFiles([mediaFile]);
+        var adUnit = vastIntegrator.playAd(response, noop);
+        this.clock.tick(1); // FF fail to set preload if there isn't at least an instruction in the middle
+        assert.equal(player.preload(), "auto");
+      });
+
       it("must play the ad using the response", function () {
         var response = new VASTResponse();