Skip to content

Commit

Permalink
Not restoring the volume when the video ends, fixing labels on demo page
Browse files Browse the repository at this point in the history
  • Loading branch information
carpasse committed Sep 3, 2015
1 parent ebcb782 commit 83e63e2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions demo/tpls/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ <h1 class="title main">videojs-vast-vpaid plugin</h1>
</div>
<div class="one-third column">
<input type="radio" name="vast-type" class="xml-type-radio" checked="checked" id="vast-sample-radio">
<label for="vast-sample-radio">VAST/VPAID sample</label>
<label for="vast-sample-radio">VAST/VPAID sample tags</label>
</div>
<div class="one-third column">
<input type="radio" name="vast-type" class="custom-type-radio" id="vast-custom-radio">
Expand All @@ -70,7 +70,7 @@ <h1 class="title main">videojs-vast-vpaid plugin</h1>
</div>
<div class="row xml-type">
<div class="twelve columns">
<label for="vast-samples">VAST XML Samples</label>
<label for="vast-samples">VAST/VPAID sample tags</label>
<select id="vast-samples" class="u-full-width xml-el">
<option selected="selected" value="http://bs.serving-sys.com/BurstingPipe/adServer.bs?cn=is&c=23&pl=VAST&pli=13569296&PluID=0&pos=1886&ord=%%CACHEBUSTER%%&cim=1">VAST serving-sys Preroll Linear</option>
<option value="http://servedby.flashtalking.com/imp/1/31714;812030;208;xml;DailyMail;640x360VASTHTML5/?cachebuster=%%CACHEBUSTER%%">VAST flashtalking Preroll Linear</option>
Expand Down Expand Up @@ -105,7 +105,7 @@ <h1 class="title main">videojs-vast-vpaid plugin</h1>
</form>
</div>
</div>
Some ad's will throw "VAST Error: on VASTClient.requestVastXML, HTTP request error with status '-1'", because that adServer is not setting the <a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS">http access control header</a>, the reason why some video player's are able to play the ad's in firefox because they do the reques by flash bypassing the browser
Some ad's will throw "VAST Error: on VASTClient.requestVastXML, HTTP request error with status '-1'", because that adServer is not setting the <a href="https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS">http access control header</a>, the reason why some video player's are able to play the ad's in firefox because they do the request by flash bypassing the browser
</div>
</div>
</body>
Expand Down
1 change: 1 addition & 0 deletions src/utils/playerUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,7 @@ playerUtils.prepareForAds = function (player) {
if (volumeSnapshot) {
player.currentTime(0);
restoreVolumeSnapshot(volumeSnapshot);
volumeSnapshot = null;
}
}

Expand Down

0 comments on commit 83e63e2

Please sign in to comment.