forked from apache/pulsar
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow user to get topic from consumer message (apache#2007) (apache#2135
) When a user receives a message, allow them to get the topic from the message itself. This is mostly useful in the case where a single consumer is subscribed to multiple topics. The change also contains a minor cleanup of the constructors in MessageImpl.
- Loading branch information
Showing
12 changed files
with
198 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
117 changes: 117 additions & 0 deletions
117
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TopicFromMessageTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.pulsar.client.impl; | ||
|
|
||
| import com.google.common.collect.Lists; | ||
| import org.apache.pulsar.client.api.Consumer; | ||
| import org.apache.pulsar.client.api.Producer; | ||
| import org.apache.pulsar.client.api.ProducerConsumerBase; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import org.testng.Assert; | ||
| import org.testng.annotations.AfterMethod; | ||
| import org.testng.annotations.BeforeMethod; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| public class TopicFromMessageTest extends ProducerConsumerBase { | ||
| private static final long testTimeout = 90000; // 1.5 min | ||
| private static final Logger log = LoggerFactory.getLogger(TopicFromMessageTest.class); | ||
|
|
||
| @Override | ||
| @BeforeMethod | ||
| public void setup() throws Exception { | ||
| super.internalSetup(); | ||
| super.producerBaseSetup(); | ||
| } | ||
|
|
||
| @Override | ||
| @AfterMethod | ||
| public void cleanup() throws Exception { | ||
| super.internalCleanup(); | ||
| } | ||
|
|
||
| @Test(timeOut = testTimeout) | ||
| public void testSingleTopicConsumerNoBatchShortName() throws Exception { | ||
| try (Consumer<byte[]> consumer = pulsarClient.newConsumer() | ||
| .topic("topic1").subscriptionName("sub1").subscribe(); | ||
| Producer<byte[]> producer = pulsarClient.newProducer() | ||
| .topic("topic1").enableBatching(false).create()) { | ||
| producer.send("foobar".getBytes()); | ||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic1"); | ||
| } | ||
| } | ||
|
|
||
| @Test(timeOut = testTimeout) | ||
| public void testSingleTopicConsumerNoBatchFullName() throws Exception { | ||
| try (Consumer<byte[]> consumer = pulsarClient.newConsumer() | ||
| .topic("my-property/my-ns/topic1").subscriptionName("sub1").subscribe(); | ||
| Producer<byte[]> producer = pulsarClient.newProducer() | ||
| .topic("my-property/my-ns/topic1").enableBatching(false).create()) { | ||
| producer.send("foobar".getBytes()); | ||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://my-property/my-ns/topic1"); | ||
| } | ||
| } | ||
|
|
||
| @Test(timeOut = testTimeout) | ||
| public void testMultiTopicConsumerNoBatchShortName() throws Exception { | ||
| try (Consumer<byte[]> consumer = pulsarClient.newConsumer() | ||
| .topics(Lists.newArrayList("topic1", "topic2")).subscriptionName("sub1").subscribe(); | ||
| Producer<byte[]> producer1 = pulsarClient.newProducer() | ||
| .topic("topic1").enableBatching(false).create(); | ||
| Producer<byte[]> producer2 = pulsarClient.newProducer() | ||
| .topic("topic2").enableBatching(false).create()) { | ||
| producer1.send("foobar".getBytes()); | ||
| producer2.send("foobar".getBytes()); | ||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic1"); | ||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic2"); | ||
| } | ||
| } | ||
|
|
||
| @Test(timeOut = testTimeout) | ||
| public void testSingleTopicConsumerBatchShortName() throws Exception { | ||
| try (Consumer<byte[]> consumer = pulsarClient.newConsumer() | ||
| .topic("topic1").subscriptionName("sub1").subscribe(); | ||
| Producer<byte[]> producer = pulsarClient.newProducer() | ||
| .topic("topic1").enableBatching(true).batchingMaxMessages(1).create()) { | ||
| producer.send("foobar".getBytes()); | ||
|
|
||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic1"); | ||
| } | ||
| } | ||
|
|
||
| @Test(timeOut = testTimeout) | ||
| public void testMultiTopicConsumerBatchShortName() throws Exception { | ||
| try (Consumer<byte[]> consumer = pulsarClient.newConsumer() | ||
| .topics(Lists.newArrayList("topic1", "topic2")).subscriptionName("sub1").subscribe(); | ||
| Producer<byte[]> producer1 = pulsarClient.newProducer() | ||
| .topic("topic1").enableBatching(true).batchingMaxMessages(1).create(); | ||
| Producer<byte[]> producer2 = pulsarClient.newProducer() | ||
| .topic("topic2").enableBatching(true).batchingMaxMessages(1).create()) { | ||
|
|
||
| producer1.send("foobar".getBytes()); | ||
| producer2.send("foobar".getBytes()); | ||
|
|
||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic1"); | ||
| Assert.assertEquals(consumer.receive().getTopicName(), "persistent://public/default/topic2"); | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.