forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add extra rsc args (pantsbuild#7863)
### Problem While we can currently pass zinc extra arguments with `--args` and passthrough args, there's no equivalent for arguments to rsc. Additionally, rsc's output is hidden unless it fails. ### Solution - Add `--extra-rsc-args` option (named to avoid clashing with any other options). - Convert the rsc invocation to use `WorkUnitLabel.COMPILER` in order to view its output upon success (allowing rsc to e.g. print timings). ### Result Rsc args can be added by setting an option, without pants changes!
- Loading branch information
1 parent
1c749f7
commit 94ed8bf
Showing
2 changed files
with
9 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters