Prep for 1.28.0.dev0 (pantsbuild#9631)

CONTRIBUTORS.md

@@ -209,6 +209,7 @@ Created by running `./build-support/bin/contributors.sh`.
 + Wolfram Arnold
 + Xaelias
 + Yi Cheng
++ Yuhan GUO
 + Yujie Chen
 + billybecker
 + Ólafur Páll Geirsson

src/python/pants/VERSION

@@ -1 +1 @@
-1.27.0rc0
+1.28.0.dev0

src/python/pants/backend/jvm/targets/junit_tests.py

@@ -5,7 +5,6 @@
 from pants.backend.jvm.subsystems.junit import JUnit
 from pants.backend.jvm.targets.jvm_target import JvmTarget
 from pants.backend.jvm.targets.runtime_platform_mixin import RuntimePlatformMixin
-from pants.base.deprecated import deprecated, deprecated_conditional
 from pants.base.exceptions import TargetDefinitionException
 from pants.base.payload import Payload
 from pants.base.payload_field import PrimitiveField
@@ -78,20 +77,6 @@ def __init__(
             if value is not None:
                 extra_env_vars[key] = str(value)
 
-        deprecated_conditional(
-            lambda: "test_platform" in kwargs,
-            "1.28.0.dev0",
-            "test_platform",
-            "Replaced with runtime_platform.",
-        )
-        if "test_platform" in kwargs and runtime_platform:
-            raise TargetDefinitionException(
-                self, "Cannot specify runtime_platform and test_platform together."
-            )
-        if "test_platform" in kwargs and not runtime_platform:
-            runtime_platform = kwargs["test_platform"]
-            del kwargs["test_platform"]
-
         payload.add_fields(
             {
                 # TODO(zundel): Do extra_jvm_options and extra_env_vars really need to be fingerprinted?
@@ -131,16 +116,6 @@ def compute_dependency_address_specs(cls, kwargs=None, payload=None):
         for address_spec in JUnit.global_instance().injectables_address_specs_for_key("library"):
             yield address_spec
 
-    @property
-    def test_platform(self):
-        return self._test_platform()
-
-    # NB: Cannot annotate the property. Extracted this to enable
-    # warning.
-    @deprecated("1.28.0.dev0", "Use runtime_platform")
-    def _test_platform(self):
-        return self.runtime_platform
-
     @property
     def concurrency(self):
         return self._concurrency

src/python/pants/notes/master.rst

@@ -4,6 +4,141 @@ Master Pre-Releases
 This document describes development releases which occur weekly from master, and which have
 not undergone the vetting associated with ``stable`` releases.
 
+1.28.0.dev0 (4/24/2020)
+-----------------------
+
+API Changes
+~~~~~~~~~~~
+
+* Rename `target-types2` goal to `target-types` and `targets()` register.py entry point to `target_types()` (#9618)
+  `PR #9618 <https://github.com/pantsbuild/pants/pull/9618>`_
+
+* Default to `--filedeps-transitive=false` and `--dependencies-transitive=false` (#9576)
+  `PR #9576 <https://github.com/pantsbuild/pants/pull/9576>`_
+
+* Require explicit specification of an AWS Lambda runtime. (#9564)
+  `PR #9564 <https://github.com/pantsbuild/pants/pull/9564>`_
+
+* Revert allowing Python targets to include `.c` files in their sources (#9583)
+  `PR #9583 <https://github.com/pantsbuild/pants/pull/9583>`_
+
+New Features
+~~~~~~~~~~~~
+
+* Add a special string <PYENV_LOCAL> to interpreter search path (#9613)
+  `PR #9613 <https://github.com/pantsbuild/pants/pull/9613>`_
+
+* Prelude file support (#9555)
+  `PR #9555 <https://github.com/pantsbuild/pants/pull/9555>`_
+
+Bugfixes
+~~~~~~~~
+
+* Temporarily disable `./pants backends` goal due to bug (#9629)
+  `PR #9629 <https://github.com/pantsbuild/pants/pull/9629>`_
+
+* fix test_platform usages (#9567)
+  `PR #9567 <https://github.com/pantsbuild/pants/pull/9567>`_
+
+* Use `FrozenDict` and `FrozenOrderedSet` for type safety with `UnionMembership` and `RegisteredTargetTypes` (#9609)
+  `PR #9609 <https://github.com/pantsbuild/pants/pull/9609>`_
+
+* Fix `zip_safe` field not being used with V2 binary (#9598)
+  `PR #9598 <https://github.com/pantsbuild/pants/pull/9598>`_
+
+* Fix python platform spec for AWS Lambdas. (#9600)
+  `PR #9600 <https://github.com/pantsbuild/pants/pull/9600>`_
+
+* Revert "Add link back to source control dir from physical workdir (#9531)" (#9601)
+  `PR #9601 <https://github.com/pantsbuild/pants/pull/9601>`_
+
+Refactoring, Improvements, and Tooling
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+* Remove our custom .tar.xz workaround. (#9617)
+  `PR #9617 <https://github.com/pantsbuild/pants/pull/9617>`_
+
+* Rename `targets.py` files to `target_types.py` (#9616)
+  `PR #9616 <https://github.com/pantsbuild/pants/pull/9616>`_
+
+* Refactor filtering of valid targets via the engine (#9614)
+  `PR #9614 <https://github.com/pantsbuild/pants/pull/9614>`_
+
+* Some logger.rs improvements (#9599)
+  `PR #9599 <https://github.com/pantsbuild/pants/pull/9599>`_
+
+* Rename `isolated_process.py` to `process.py` (#9608)
+  `PR #9608 <https://github.com/pantsbuild/pants/pull/9608>`_
+
+* Factor up flexible handling of invalid target types (#9605)
+  `PR #9605 <https://github.com/pantsbuild/pants/pull/9605>`_
+
+* Move private engine code into `engine/internals` (#9597)
+  `PR #9597 <https://github.com/pantsbuild/pants/pull/9597>`_
+
+* Break setup_logger into two functions (#9592)
+  `PR #9592 <https://github.com/pantsbuild/pants/pull/9592>`_
+
+* Factor up common Configuration code (#9557)
+  `PR #9557 <https://github.com/pantsbuild/pants/pull/9557>`_
+
+* Improve V2 UI messages by describing the scope of the work being done (#9588)
+  `PR #9588 <https://github.com/pantsbuild/pants/pull/9588>`_
+
+* Add `DeduplicatedCollection` to newtype `FrozenOrderedSet` in rules (#9590)
+  `PR #9590 <https://github.com/pantsbuild/pants/pull/9590>`_
+
+* Some ExceptionSink refactors (#9584)
+  `PR #9584 <https://github.com/pantsbuild/pants/pull/9584>`_
+
+* Logger cleanup (#9578)
+  `PR #9578 <https://github.com/pantsbuild/pants/pull/9578>`_
+
+* Reorganize `engine/legacy` to only have legacy engine code (#9591)
+  `PR #9591 <https://github.com/pantsbuild/pants/pull/9591>`_
+
+* Remove "Executing process" text from V2 UI (#9568)
+  `PR #9568 <https://github.com/pantsbuild/pants/pull/9568>`_
+
+* Add `engine/collection.py` for the `Collection` newtype (#9586)
+  `PR #9586 <https://github.com/pantsbuild/pants/pull/9586>`_
+
+* Add `engine/unions.py` to consolidate union types into one file (#9580)
+  `PR #9580 <https://github.com/pantsbuild/pants/pull/9580>`_
+
+* Add `engine/addresses.py` for consolidated `Address` imports in V2 (#9575)
+  `PR #9575 <https://github.com/pantsbuild/pants/pull/9575>`_
+
+* Use rust cpu_count crate to determine v2 UI swim lanes (#9574)
+  `PR #9574 <https://github.com/pantsbuild/pants/pull/9574>`_
+
+* Reorganize `rules/core` into `core/goals`, `core/project_info`, `core/util_rules`, and `core/target_types.py` (#9572)
+  `PR #9572 <https://github.com/pantsbuild/pants/pull/9572>`_
+
+Testing
+~~~~~~~
+
+* Fix test import and generic alias failures. (#9626)
+  `PR #9626 <https://github.com/pantsbuild/pants/pull/9626>`_
+
+* Use `--go-chroot` internally (#9579)
+  `PR #9579 <https://github.com/pantsbuild/pants/pull/9579>`_
+
+Documentation
+~~~~~~~~~~~~~
+
+* Fixes for the proxy page. (#9628)
+  `PR #9628 <https://github.com/pantsbuild/pants/pull/9628>`_
+
+* Add description for the validate goal. (#9602)
+  `PR #9602 <https://github.com/pantsbuild/pants/pull/9602>`_
+
+* Fix typos. (#9607)
+  `PR #9607 <https://github.com/pantsbuild/pants/pull/9607>`_
+
+* Fix typo in V1 Python interpreter selection error message (#9589)
+  `PR #9589 <https://github.com/pantsbuild/pants/pull/9589>`_
+
 1.27.0rc0 (4/17/2020)
 ----------------------
 

src/python/pants/task/testrunner_task_mixin.py

@@ -428,7 +428,7 @@ def register_options(cls, register):
             type=bool,
             default=False,
             fingerprint=True,
-            removal_version="1.28.0.dev0",
+            removal_version="1.28.0.dev2",
             removal_hint=(
                 "This option is going away for better isolation of tests, which provides "
                 "better caching. This also prepares for upgrading to the V2 test implementation,"

tests/python/pants_test/backend/jvm/targets/test_junit_tests.py

@@ -87,18 +87,3 @@ def test_implicit_junit_dep(self):
             ["JarLibrary(//:junit_library)", "Target(//:target)"],
             sorted(str(x) for x in test2.dependencies),
         )
-
-    def test_test_platform_sets_runtime_platform(self):
-        init_subsystem(JUnit)
-        target = self.make_target("//:test1", JUnitTests, sources=[], test_platform="b")
-        assert target.payload.runtime_platform == "b"
-
-    def test_runtime_and_test_platform_error(self):
-        with self.assertRaisesWithMessage(
-            TargetDefinitionException,
-            "Invalid target JUnitTests(address not yet set): "
-            "Cannot specify runtime_platform and test_platform together.",
-        ):
-            self.make_target(
-                "//:test1", JUnitTests, sources=[], runtime_platform="a", test_platform="b"
-            )