Skip to content

Commit

Permalink
Improve a couple of log messages. (pantsbuild#13121)
Browse files Browse the repository at this point in the history
- Our log messages are usually capitalized, so the preserving local process dir one should be too.
- backtick-double-quote-path is much harder to select and copy than just the raw path string.
- The dot at the end of the getting-help URL might be selected and copied, which would be wrong.

[ci skip-build-wheels]
  • Loading branch information
benjyw authored Oct 6, 2021
1 parent ffcebaf commit 044af4a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/python/pants/init/logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ def formatException(self, exc_info):
)

return (
f"{stacktrace}\n\n({debug_instructions}See {doc_url('troubleshooting')} for common issues. "
f"Consider reaching out for help: {doc_url('getting-help')}.)"
f"{stacktrace}\n\n{debug_instructions}\nSee {doc_url('troubleshooting')} for common "
f"issues.\nConsider reaching out for help: {doc_url('getting-help')}\n"
)


Expand Down
5 changes: 3 additions & 2 deletions src/rust/engine/process_execution/src/local.rs
Original file line number Diff line number Diff line change
Expand Up @@ -284,8 +284,9 @@ impl super::CommandRunner for CommandRunner {
// that the temporary directory will no longer be automatically deleted when dropped.
let preserved_path = workdir.into_path();
info!(
"preserving local process execution dir `{:?}` for {:?}",
preserved_path, req.description
"Preserving local process execution dir {} for {:?}",
preserved_path.display(),
req.description
);
(preserved_path, None)
}
Expand Down

0 comments on commit 044af4a

Please sign in to comment.