forked from pantsbuild/pants
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Render all frames of a failure in Engine tracebacks (pantsbuild#10510)
### Problem Currently only workunits with user-visible descriptions will be rendered in engine tracebacks, and this inhibits debugging. ### Solution Since `--print-exception-stacktrace` is disabled by default, we can safely be more specific, and render the workunit name (ie, rule name) if a workunit does not have a description. ### Result ``` Engine traceback: in `dependencies` goal Traceback (most recent call last): <snip> ``` becomes ``` Engine traceback: in select in `dependencies` goal in pants.engine.internals.graph.resolve_targets in pants.engine.internals.graph.resolve_target in pants.engine.internals.graph.generate_subtargets in pants.engine.internals.build_files.find_target_adaptor Traceback (most recent call last): <snip> ``` [ci skip-build-wheels]
- Loading branch information
Showing
3 changed files
with
9 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters