Skip to content

Commit

Permalink
Fix @rule effect validation for not cacheable types. (pantsbuild#…
Browse files Browse the repository at this point in the history
…14069)

pantsbuild#13178 added additional validation of use of `Effect`s in `@goal_rules` but it was accidentally unreachable. 

[ci skip-rust]
[ci skip-build-wheels]
  • Loading branch information
stuhood authored Jan 4, 2022
1 parent 5baf325 commit 920591e
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/python/pants/engine/rules.py
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,6 @@ def validate_requirements(
awaitables: Tuple[AwaitableConstraints, ...],
cacheable: bool,
) -> None:
if not cacheable:
return
# TODO: Technically this will also fire for an @_uncacheable_rule, but we don't expose those as
# part of the API, so it's OK for these errors not to mention them.
for ty in parameter_types:
Expand Down

0 comments on commit 920591e

Please sign in to comment.