Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement a simple WireCells service integrating pydio SDKs - WPB-15664 #2470

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

El-Fitz
Copy link
Contributor

@El-Fitz El-Fitz commented Feb 4, 2025

TaskWPB-15664 [iOS] Implement a WireCells service for files management

Issue

Create a simple service integrating the Pydio and AWS SDKs for files listing & upload.

Testing

Open the test in the test target.
Replace the nil secret key with the one from 1Password.
Run the tests.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@El-Fitz El-Fitz self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 418e9a1.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 4, 2025

Datadog Report

Branch report: feat/pydio-sdks-integration
Commit report: 7614091
Test service: wire-ios-mono

✅ 0 Failed, 1689 Passed, 26 Skipped, 2m 1.57s Total Time

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: I forgot in my first PR. Please do these additional steps to ensure this package is a good citizen on our CI: https://wearezeta.atlassian.net/wiki/spaces/IOS/pages/1699446800/How+to+add+a+project+or+package+to+Wire-iOS. Afterwards I will re-approve.

WireCells/Sources/API/WireCellsService.swift Outdated Show resolved Hide resolved
WireCells/Tests/WireCellsTests/WireCellsTests.swift Outdated Show resolved Hide resolved
WireCells/Sources/Bindings/WireCellsBindings.swift Outdated Show resolved Hide resolved
@El-Fitz
Copy link
Contributor Author

El-Fitz commented Feb 4, 2025

https://wearezeta.atlassian.net/wiki/spaces/IOS/pages/1699446800/How+to+add+a+project+or+package+to+Wire-iOS

@samwyndham The current tests can't be run in CI. And they wouldn't make sense. The current tests are just a way of running the different methods of the SDK. I'll have to clear a few things with Charles before implementing snapshots for the network requests.

@El-Fitz El-Fitz force-pushed the feat/pydio-sdks-integration branch from 5bb0f78 to e3ce005 Compare February 4, 2025 17:46
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just added some comments. For CI, not a blocker at the moment, but as I guess this grows, upcoming tests would need to be run by CI, so either setup and ignore current tests or setup on a later PR

WireCells/Sources/API/WireCellsFileQueryError.swift Outdated Show resolved Hide resolved
WireCells/Sources/API/WireCellsFileUploadError.swift Outdated Show resolved Hide resolved
WireCells/Sources/API/WireCellsService.swift Outdated Show resolved Hide resolved
WireCells/Tests/WireCellsTests/WireCellsTests.swift Outdated Show resolved Hide resolved
WireCells/Tests/WireCellsTests/WireCellsTests.swift Outdated Show resolved Hide resolved
@El-Fitz El-Fitz force-pushed the feat/pydio-sdks-integration branch from e3ce005 to a760f34 Compare February 7, 2025 13:32
@El-Fitz El-Fitz enabled auto-merge February 7, 2025 13:33
@El-Fitz El-Fitz force-pushed the feat/pydio-sdks-integration branch from a760f34 to 418e9a1 Compare February 7, 2025 13:56
@El-Fitz El-Fitz added this pull request to the merge queue Feb 7, 2025
Merged via the queue into develop with commit 72d09a3 Feb 7, 2025
9 checks passed
@El-Fitz El-Fitz deleted the feat/pydio-sdks-integration branch February 7, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants