-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement a simple WireCells service integrating pydio SDKs - WPB-15664 #2470
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 418e9a1. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 1689 Passed, 26 Skipped, 2m 1.57s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: I forgot in my first PR. Please do these additional steps to ensure this package is a good citizen on our CI: https://wearezeta.atlassian.net/wiki/spaces/IOS/pages/1699446800/How+to+add+a+project+or+package+to+Wire-iOS. Afterwards I will re-approve.
WireCells/Sources/Implementation/WireCellsServiceImplementation.swift
Outdated
Show resolved
Hide resolved
@samwyndham The current tests can't be run in CI. And they wouldn't make sense. The current tests are just a way of running the different methods of the SDK. I'll have to clear a few things with Charles before implementing snapshots for the network requests. |
5bb0f78
to
e3ce005
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just added some comments. For CI, not a blocker at the moment, but as I guess this grows, upcoming tests would need to be run by CI, so either setup and ignore current tests or setup on a later PR
WireCells/Sources/Implementation/WireCellsServiceImplementation.swift
Outdated
Show resolved
Hide resolved
e3ce005
to
a760f34
Compare
a760f34
to
418e9a1
Compare
Issue
Create a simple service integrating the Pydio and AWS SDKs for files listing & upload.
Testing
Open the test in the test target.
Replace the nil secret key with the one from 1Password.
Run the tests.
Checklist
[WPB-XXX]
.