Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proteus send message error missing logic - WPB-16116 #2535

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-16116 [iOS] sent messages from iOS never appear on any other client

Issue

Context: first Proteus message on a fresh install doesn't show up

Cause: Some logic was missing in this PR to fix a request loop issue

When getting a network error, we'll try handle the proteus failure which either returns a set of missing clients qualified IDs or throws a specific MessageSendError.
-> if it throws MessageSendError, we'll retry a couple of times and then throws the error (done in PR)
-> If we do get the set of client qualified IDs, we do nothing, we don't try to actually resend the message.

Solution: add missing code to send the message again

Testing

Fresh install the app
Try to send a first message in a group
Message should show up

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian changed the base branch from develop to release/cycle-3.118 February 13, 2025 11:56
@caldrian caldrian force-pushed the fix/proteus-send-message-error-missing-logic-cherry-pick branch from e1a3843 to 8ae6833 Compare February 13, 2025 11:58
Copy link
Contributor

@caldrian caldrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forwarding the suggestion to create a regression test:
#2534 (review)

@caldrian caldrian requested a review from jullianm February 13, 2025 11:59
Copy link
Contributor Author

Test Results

1 191 tests   1 191 ✅  1m 37s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 8ae6833.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/proteus-send-message-error-missing-logic-cherry-pick
Commit report: 96c1518
Test service: wire-ios-mono

✅ 0 Failed, 1092 Passed, 0 Skipped, 1m 37.03s Total Time

@jullianm jullianm merged commit c26a23b into release/cycle-3.118 Feb 13, 2025
8 of 9 checks passed
@jullianm jullianm deleted the fix/proteus-send-message-error-missing-logic-cherry-pick branch February 13, 2025 12:47
zenkins pushed a commit that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants