Skip to content

Commit

Permalink
add test to check axes are rendered
Browse files Browse the repository at this point in the history
  • Loading branch information
@nicgirault
nicgirault committed Mar 12, 2017
1 parent db2f4a1 commit 3768f98
Show file tree
Hide file tree
Showing 3 changed files with 143 additions and 84 deletions.
222 changes: 142 additions & 80 deletions src/axes.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,113 +2,175 @@ import { describe, it } from 'mocha'
import chai from 'chai'
import { spy } from 'sinon'
import sinonChai from 'sinon-chai'
import jsdom from 'mocha-jsdom'
import forEach from 'lodash/forEach'
import { _buildAxesData } from './axes'
import { select, selectAll } from 'd3-selection'
import Circos from './circos'

const expect = chai.expect
chai.use(sinonChai)

describe('Axes', () => {
it('should log an warning if no position and spacing are defined', () => {
spy(console, 'warn')
const axes = _buildAxesData({
axes: [{color: 'red'}]
describe('_buildAxesData', () => {
it('should log an warning if no position and spacing are defined', () => {
spy(console, 'warn')
const axes = _buildAxesData({
axes: [{color: 'red'}]
})
expect(console.warn).to.have.been.called.calledOnce
expect(axes.length).to.equal(0)
console.warn.restore()
})
expect(console.warn).to.have.been.called.calledOnce
expect(axes.length).to.equal(0)
console.warn.restore()
})

it('should return the axe group if position attribute is defined', () => {
const axes = _buildAxesData({
axes: [
{
position: 12
}
],
opacity: 1
it('should return the axe group if position attribute is defined', () => {
const axes = _buildAxesData({
axes: [
{
position: 12
}
],
opacity: 1
})
expect(axes.length).to.equal(1)
expect(axes[0].value).to.equal(12)
expect(axes[0].opacity).to.equal(1)
expect(axes[0].color).to.equal('#d3d3d3')
expect(axes[0].thickness).to.equal(1)
})
expect(axes.length).to.equal(1)
expect(axes[0].value).to.equal(12)
expect(axes[0].opacity).to.equal(1)
expect(axes[0].color).to.equal('#d3d3d3')
expect(axes[0].thickness).to.equal(1)
})

forEach([
{
spacing: 2,
min: 10,
max: 20,
expected: [10, 12, 14, 16, 18]
},
{
spacing: 2,
start: 14,
min: 10,
max: 20,
expected: [14, 16, 18]
},
{
spacing: 2,
end: 14,
min: 10,
max: 20,
expected: [10, 12]
}
], (dataset) => {
it('should return a range of axes according to spacing, start and end attributes', () => {
forEach([
{
spacing: 2,
min: 10,
max: 20,
expected: [10, 12, 14, 16, 18]
},
{
spacing: 2,
start: 14,
min: 10,
max: 20,
expected: [14, 16, 18]
},
{
spacing: 2,
end: 14,
min: 10,
max: 20,
expected: [10, 12]
}
], (dataset) => {
it('should return a range of axes according to spacing, start and end attributes', () => {
const axes = _buildAxesData({
axes: [
{
spacing: dataset.spacing,
start: dataset.start,
end: dataset.end
}
],
cmin: dataset.min,
cmax: dataset.max
})
expect(axes.length).to.equal(dataset.expected.length)
forEach(axes, (axis, i) => {
expect(axis.value).to.equal(dataset.expected[i])
})
})
})

it('should use axe group color, opacity and thickness if defined', () => {
const axes = _buildAxesData({
axes: [
{
spacing: dataset.spacing,
start: dataset.start,
end: dataset.end
position: 12,
opacity: 0.5,
color: 'red',
thickness: 3
}
],
cmin: dataset.min,
cmax: dataset.max
opacity: 1
})
expect(axes.length).to.equal(dataset.expected.length)
forEach(axes, (axis, i) => {
expect(axis.value).to.equal(dataset.expected[i])
expect(axes.length).to.equal(1)
expect(axes[0].value).to.equal(12)
expect(axes[0].opacity).to.equal(0.5)
expect(axes[0].color).to.equal('red')
expect(axes[0].thickness).to.equal(3)
})

it('should create range axes and simple axis', () => {
const axes = _buildAxesData({
axes: [
{
position: 12
},
{
spacing: 2
}
],
opacity: 1,
cmin: 10,
cmax: 20
})
expect(axes.length).to.equal(6)
})
})

it('should use axe group color, opacity and thickness if defined', () => {
const axes = _buildAxesData({
describe('renderAxes', function () {
jsdom()
const configuration = {
min: 10,
max: 20,
axes: [
{
position: 12,
position: 2,
opacity: 0.5,
color: 'red',
thickness: 3
thickness: 2,
color: 'grey'
}
],
opacity: 1
]
}
beforeEach(function () {
document.body.innerHTML = '<div id="chart"></div>'
this.instance = new Circos({container: '#chart', width: 350, height: 350})
.layout([{id: 'january', len: 31}, {id: 'february', len: 28}])
})
expect(axes.length).to.equal(1)
expect(axes[0].value).to.equal(12)
expect(axes[0].opacity).to.equal(0.5)
expect(axes[0].color).to.equal('red')
expect(axes[0].thickness).to.equal(3)
})

it('should create range axes and simple axis', () => {
const axes = _buildAxesData({
axes: [
{
position: 12
},
{
spacing: 2
}
],
opacity: 1,
cmin: 10,
cmax: 20
forEach([
{
track: 'line',
data: [
{block_id: 'january', position: 1, value: 1},
{block_id: 'february', position: 2, value: 4}
]
},
{
track: 'scatter',
data: [
{block_id: 'january', position: 1, value: 1},
{block_id: 'february', position: 2, value: 4}
]
},
{
track: 'histogram',
data: [
{block_id: 'january', start: 1, end: 2, value: 1},
{block_id: 'february', start: 1, end: 2, value: 4}
]
}
], (dataset) => {
it(`should render the axes for track ${dataset.track}`, function () {
this.instance[dataset.track]('track1', dataset.data, configuration).render()
const axes = selectAll('.axis')
expect(axes.size()).to.equal(2)
forEach(axes.nodes(), (axisNode, i) => {
const axis = select(axisNode)
expect(axis.attr('stroke')).to.equal('grey')
expect(axis.attr('stroke-width')).to.equal('2')
expect(axis.attr('opacity')).to.equal('0.5')
})
})
})
expect(axes.length).to.equal(6)
})
})
4 changes: 0 additions & 4 deletions src/tracks/Highlight.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ const defaultConf = assign({
strokeWidth: {
value: 0,
iteratee: true
},
axes: {
value: [],
iteratee: false
}
}, radial, common)

Expand Down
1 change: 1 addition & 0 deletions src/tracks/Track.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {arc} from 'd3-shape'
import {getConf} from '../config-utils'
import {buildScale} from '../utils'
import {buildColorValue} from '../colors'
import {renderAxes} from '../axes'

/**
* Abstract class used by all tracks
Expand Down

0 comments on commit 3768f98

Please sign in to comment.